Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp4696463ybb; Tue, 7 Apr 2020 12:32:56 -0700 (PDT) X-Google-Smtp-Source: APiQypJrewrb1idagy3zKD23AFQley48jyeTdIYRI9Or3wwAqFNPz4exqk6HqtOHRk0cTgrscv2M X-Received: by 2002:a9d:7c90:: with SMTP id q16mr3085432otn.104.1586287976786; Tue, 07 Apr 2020 12:32:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586287976; cv=none; d=google.com; s=arc-20160816; b=mJLc6O9t4T09q/jjmWwVJZ4BwaJe1s4ISYUUJneS1p/ggnQ/DrZ5aNnV+xn1DviF6+ LKx/cOk/y94bMCantwzouHwe5qNodmd0fUTOm9WdHtKfmTAFpMyyR1fmKcyarpLkLfh5 EovL5L2gUb+b2SrQ69vo8/a76jBhqFpEvjIWCDjkYPWkYjXt/zJzXPGLL68pqX+LsIjP i/Yfi6bmx2y+sCswczSyQThKRWr/B8oUZ2J2i1E/CBrRrCx86qmmXsjL5/DoG8EPP/kk an+kF5yjajx2M1YpDsagr4642m2BeT9KX03jSewO+mniTzpHZK2AimwC/UzNZ8/GRziL 3tkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=ZGd6yjfMnvNcpfDgM1xe7CnkRw1jp0wH+C8zp4u4v9A=; b=sLdH4wmbJipWCbTsy2/hqMdTGQnxxApDaZ+YQm7SggLXHCS7sfkffEt1lC0yVT/uuY /HtWLtAsycky+c1b3SghFoccWANedun2FzFl1VZO9HnGRDkjv/5SHvoeA+LALlyqiXLn ls756Nue7ZqAWoZ31KOScscy9dKiPTOIBEQ/+Mkh4i8wjs77/rWFgkHlJSXoaXoCW9Fo 0mFmovSL29S28AdizPZEdim0kBwGTVwR8wih2Bn38nMWoBLJNpUGq88eAEHKkZFpDe5l Zxp3unSQ9XkLalIud/2zGIu5VKlED30ejnKgDeCrU/FYgdTcaYARMz9LdctKKFXo6ZvH kH3Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w5si1542892ote.129.2020.04.07.12.32.41; Tue, 07 Apr 2020 12:32:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726725AbgDGTcj (ORCPT + 99 others); Tue, 7 Apr 2020 15:32:39 -0400 Received: from smtp07.smtpout.orange.fr ([80.12.242.129]:54369 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726719AbgDGTcj (ORCPT ); Tue, 7 Apr 2020 15:32:39 -0400 Received: from localhost.localdomain ([93.22.37.82]) by mwinf5d42 with ME id PvYb220081mLNr903vYbaZ; Tue, 07 Apr 2020 21:32:37 +0200 X-ME-Helo: localhost.localdomain X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Tue, 07 Apr 2020 21:32:37 +0200 X-ME-IP: 93.22.37.82 From: Christophe JAILLET To: imitsyanko@quantenna.com, avinashp@quantenna.com, smatyukevich@quantenna.com, kvalo@codeaurora.org, davem@davemloft.net, huangfq.daxian@gmail.com Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET Subject: [PATCH] qtnfmac: Simplify code in _attach functions Date: Tue, 7 Apr 2020 21:32:33 +0200 Message-Id: <20200407193233.9439-1-christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org There is no need to re-implement 'netdev_alloc_skb_ip_align()' here. Keep the code simple. Signed-off-by: Christophe JAILLET --- drivers/net/wireless/quantenna/qtnfmac/pcie/pearl_pcie.c | 2 +- drivers/net/wireless/quantenna/qtnfmac/pcie/topaz_pcie.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/quantenna/qtnfmac/pcie/pearl_pcie.c b/drivers/net/wireless/quantenna/qtnfmac/pcie/pearl_pcie.c index dbb241106d8a..eb67b66b846b 100644 --- a/drivers/net/wireless/quantenna/qtnfmac/pcie/pearl_pcie.c +++ b/drivers/net/wireless/quantenna/qtnfmac/pcie/pearl_pcie.c @@ -286,7 +286,7 @@ static int pearl_skb2rbd_attach(struct qtnf_pcie_pearl_state *ps, u16 index) struct sk_buff *skb; dma_addr_t paddr; - skb = __netdev_alloc_skb_ip_align(NULL, SKB_BUF_SIZE, GFP_ATOMIC); + skb = netdev_alloc_skb_ip_align(NULL, SKB_BUF_SIZE); if (!skb) { priv->rx_skb[index] = NULL; return -ENOMEM; diff --git a/drivers/net/wireless/quantenna/qtnfmac/pcie/topaz_pcie.c b/drivers/net/wireless/quantenna/qtnfmac/pcie/topaz_pcie.c index dbf3c5fd751f..d1b850aa4657 100644 --- a/drivers/net/wireless/quantenna/qtnfmac/pcie/topaz_pcie.c +++ b/drivers/net/wireless/quantenna/qtnfmac/pcie/topaz_pcie.c @@ -247,7 +247,7 @@ topaz_skb2rbd_attach(struct qtnf_pcie_topaz_state *ts, u16 index, u32 wrap) struct sk_buff *skb; dma_addr_t paddr; - skb = __netdev_alloc_skb_ip_align(NULL, SKB_BUF_SIZE, GFP_ATOMIC); + skb = netdev_alloc_skb_ip_align(NULL, SKB_BUF_SIZE); if (!skb) { ts->base.rx_skb[index] = NULL; return -ENOMEM; -- 2.20.1