Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v3 2/2] mac80211: Allow deleting stations in ibss mode to
 reset their state
To:     Nicolas Cavallari <cavallar@lri.fr>, linux-wireless@vger.kernel.org
Cc:     Johannes Berg <johannes@sipsolutions.com>
References: <20200305135754.12094-1-cavallar@lri.fr>
 <20200305135754.12094-2-cavallar@lri.fr>
From:   Koen Vandeputte <koen.vandeputte@ncentric.com>
Message-ID: <bc2934fe-ee0b-c593-e866-692487e06d4e@ncentric.com>
Date:   Wed, 8 Apr 2020 13:56:52 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <20200305135754.12094-2-cavallar@lri.fr>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk


On 05.03.20 14:57, Nicolas Cavallari wrote:
> From: Nicolas Cavallari <nicolas.cavallari@green-communications.fr>
>
> Set the NL80211_EXT_FEATURE_DEL_IBSS_STA if the interface support IBSS
> mode, so that stations can be reset from user space.
>
> mac80211 already deletes stations by itself, so mac80211 drivers must
> already support this.
>
> This has been successfully tested with ath9k.
>
> Signed-off-by: Nicolas Cavallari <nicolas.cavallari@green-communications.fr>
>
> ---
> v3: spelling fixes in commit message.
> ---
>   net/mac80211/main.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/net/mac80211/main.c b/net/mac80211/main.c
> index 944e86da5c65..bc7fd67dc987 100644
> --- a/net/mac80211/main.c
> +++ b/net/mac80211/main.c
> @@ -1081,6 +1081,10 @@ int ieee80211_register_hw(struct ieee80211_hw *hw)
>   				      NL80211_EXT_FEATURE_EXT_KEY_ID);
>   	}
>   
> +	if (local->hw.wiphy->interface_modes & BIT(NL80211_IFTYPE_ADHOC))
> +		wiphy_ext_feature_set(local->hw.wiphy,
> +				      NL80211_EXT_FEATURE_DEL_IBSS_STA);
> +
>   	/*
>   	 * Calculate scan IE length -- we need this to alloc
>   	 * memory and to subtract from the driver limit. It

Hi Nicolas,


I took these patches for a thorough spin offshore (combined with your 
quick wpa_sup change)


Quick test setup overview:

- Device mounted on top of a vessel, sailing around in windfarms.
- Lots of turbines are equiped with 4x 90deg sectors
- 802.11n HT40 2x2 custom mesh over IBSS, using Dynack
- As the vessel moves around,  IBSS links are continuously dropped and 
re-added throughout the field
- Output of my app, fyi:  https://pastebin.com/raw/vtZSwHC9

I've made 2 identical builds, one containing your patches and one without.

When your patches are used:

--> On devices with multiple radio's, all radio's went deaf within a few 
minutes without any notice in logs.

--> Only a reboot solved the issue but everything goes deaf again within 
a few minutes. (after dropping/adding some links)


Any idea?


Thanks,

Koen