Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1771426ybb; Thu, 9 Apr 2020 08:44:07 -0700 (PDT) X-Google-Smtp-Source: APiQypJnK5oS+a0QVK+ldSOatU7rYBa2yYf6ZxseUgwQVNFmJjc4DBVAaPFluvbsy44GFqdayIIC X-Received: by 2002:a37:5208:: with SMTP id g8mr425332qkb.83.1586447047491; Thu, 09 Apr 2020 08:44:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586447047; cv=none; d=google.com; s=arc-20160816; b=nUcHw4q/QIWpEe6M3oWbTN6i/oWCSrLWI1lYgCRoewu2JkH1+BUkga1m28+hAHOhnN Va1Q1iqrZipNkGNAZSvJl7AYz7ugX42t3v8jW1OqCo2hx2uZjVcvYtzqISwBXodag8aw FvZPA7L6KWxRG8DvRr28qPQylbTQ03ognwUl61aZJzKvD+OW7mKD2d3kTGu9/hC6H8B3 nbOjwjDQXMjepETzKbh4Sd4vwzcZug++K7rO6qinZ6sNw7j+dccjMO8WH6DG90Z5Prh+ hlnTvc4APjtCmnMYMiSZtpM9Wc7UZ2j3UHsLOEM8LEOumRVsb5hIUstu3JwuFP5hZpbM iwnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:dmarc-filter :dkim-signature; bh=HXX12wmUv3R/HEJbd2SH/6l+DxGPnMH2DaiOr0PZbPs=; b=p23n8CQJZzPS68k/e0dvAt3K3UL8Ai6awYit8o2MBo4HW3R9K1xqI4JnpZis7BiSLi Bi5DVVPOFnsiEIdQNnjoDaKufCD2p7f0r+44MkjHG9Rmve99bIY5yVbfOq1e+rGMn5Ps 0UpwZxrtpNAdXEDYg+pZ/EL9Y5cY4uRKh/Aw5ZNNB/1Xsjrd/je79LdRpQMcPeV7luW+ Ib5pdWIHFZ6GAqHVK3He85akpwc28viVEf+UI+lh+8O8SI5imYNzl8SZM35q0ip9l4p0 57gYIBIUhuvHMMyDh8dyF5Jv3N5UkU2pKO8ERYOq7a3W8GCpsy+BmdTEgWtcZ3H9Jq6P Xvfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=p+279hiq; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v46si5668329qtb.107.2020.04.09.08.43.46; Thu, 09 Apr 2020 08:44:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=p+279hiq; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728220AbgDIPnC (ORCPT + 99 others); Thu, 9 Apr 2020 11:43:02 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:63843 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728167AbgDIPnC (ORCPT ); Thu, 9 Apr 2020 11:43:02 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1586446982; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=HXX12wmUv3R/HEJbd2SH/6l+DxGPnMH2DaiOr0PZbPs=; b=p+279hiqcaOAoo4XnXGAA8YBw9ngCYTz7T/vEvcoltCsf5PjldCTfkEd0bgGaalI+EjrHpom dswDp3qVbmLI9TelWBEoJrXtk3YPcZNYov3ufNZ1qQ8y2yO14lvC7MaoKZwRUmwRs5hgnVYl 38cKtOILN3igHY2autm4yNwaTi8= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e8f4279.7f7ecf1c1ed8-smtp-out-n01; Thu, 09 Apr 2020 15:42:49 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 180B3C4478C; Thu, 9 Apr 2020 15:42:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id A391FC432C2; Thu, 9 Apr 2020 15:42:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A391FC432C2 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Wen Gong Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH v9 3/4] ath10k: add htt TX bundle for sdio References: <20200212080415.31265-1-wgong@codeaurora.org> <20200212080415.31265-4-wgong@codeaurora.org> <87pncgu2ba.fsf@kamboji.qca.qualcomm.com> <36ee3bed6f7cd200df0755209ec6bbc2@codeaurora.org> Date: Thu, 09 Apr 2020 18:42:41 +0300 In-Reply-To: <36ee3bed6f7cd200df0755209ec6bbc2@codeaurora.org> (Wen Gong's message of "Thu, 09 Apr 2020 23:29:20 +0800") Message-ID: <87lfn4u0lq.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Wen Gong writes: > On 2020-04-09 23:05, Kalle Valo wrote: > >>> + ep->tx_credits -= credits; >>> + ath10k_dbg(ar, ATH10K_DBG_HTC, >>> + "htc ep %d consumed %d credits (total %d)\n", >> >> "htc ep %d consumed %d credits total %d\n" >> >> [...] >> >>> + ath10k_dbg(ar, ATH10K_DBG_HTC, "bundle skb: len:%d\n", >>> bundle_skb->len); >> >> "htc bundle skb len %d\n" >> >> In other words, start with "htc" and don't use colons or parenthesis. >> This applies to most of debug messages in this patch. > > I will change the log and other log and sent v10. > but "ath10k: disable TX complete indication of htt for sdio" and > "ath10k: change ATH10K_SDIO_BUS_REQUEST_MAX_NUM from 64 to 1024" has > appied to ath-next, > so I only need to send the left 2 patches: > "ath10k: add htt TX bundle for sdio" and "ath10k: enable alt data of > TX path for sdio", right? Correct, I already applied patches 1 and 2. But before you resend patches 3-4 did you see my question about creating a new thread, is it really necessary? -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches