Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp395175ybb; Fri, 10 Apr 2020 02:13:51 -0700 (PDT) X-Google-Smtp-Source: APiQypIbuVw3Sk71JVAcD/ZMEMkkxooIrHjnCjIxLagWD6pbTmC/+rjwsmkghb3g+8QIOFnrVOVq X-Received: by 2002:a05:6214:a08:: with SMTP id dw8mr4118081qvb.58.1586510031267; Fri, 10 Apr 2020 02:13:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586510031; cv=none; d=google.com; s=arc-20160816; b=t25dltI6KBdFSPbwz3Xd+BaKNkt8lx34Ru+D8caD7a/sR1KxBGpb+JZbMRmGQm/wXq nXNiTJ4dEm1nM8p6LPmsujkmb9o3Ax4t0GF8PeNIlCtX+JwZWQG09F5LONhL49MFAMuZ HmSDTlSxatTg5shQlehYbX67Zdaci04ftLkkHnCw62uEtbdoq6UXs0FzXb/f5n223bzl GT0AmlyPxesVpIqmy5CRbdPIF7HDFyIOXGkwb5ZBqUedPYdv/a3fK6wTCrHex0/3r+ne 4BdU/UTbE6Gt01nL9OH07nn35qB2OaHcoWINR6shjRRuv8fOEMB2cyjW3EklCtUdolUW MSSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature; bh=b2CpFz454BDdwSqjxr1G6oZhbHKRvHfmuEllgNAzRl4=; b=CLR9ZwWHAxFyJcljZqb2QRUoYwqN2CVV63iarmM/NBA8CtffByHuz2YRWXQTxNvcBm LM8PB5Bcmyc/MgMsjGUUqERYasbBLYIZlAle2xZ6pwEFh+JTzpDYvvQwrY+crSV1fLFm i4+UD05hD6KZaNeBE9c24xIs9idNSVCRYmuY66XHUMD4YxIgiMlR+RdoHmcUGQ2uJ9RB XZ1Zs652INoXTCh9XXYTJPY/vSzliUFlOwmTuGsRkSf5BcjdysuJClI9eNI8uB6hb4nM kNoNkifJtTADzdILycE19Qr8oinaa+L1rjmQXjKxSLUXY42NRsoR5aYajccm40dFC7hi nCxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=aMd2+d5p; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z19si844312qtn.187.2020.04.10.02.13.36; Fri, 10 Apr 2020 02:13:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=aMd2+d5p; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726703AbgDJJMG (ORCPT + 99 others); Fri, 10 Apr 2020 05:12:06 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:55894 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725897AbgDJJMC (ORCPT ); Fri, 10 Apr 2020 05:12:02 -0400 Received: by mail-wm1-f66.google.com with SMTP id e26so1842678wmk.5 for ; Fri, 10 Apr 2020 02:12:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=b2CpFz454BDdwSqjxr1G6oZhbHKRvHfmuEllgNAzRl4=; b=aMd2+d5pjt/YhcQB6BbQ7FOikvw1vYCKys3R3QEmkI6Kuar1sQNy7O47jG/TbMq9YQ QRWMyNFicIA8c1/4MRT5ymxHSswxEpO6OOeO1NL0pc3mw2knsEWtRIBLtPPiwVoDr7Nb 4LC4R/r9PlKF8ikSwBZ/dqHPfMJQIwYpT9wfA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=b2CpFz454BDdwSqjxr1G6oZhbHKRvHfmuEllgNAzRl4=; b=Z4w9DCmoEQy5B7zgJx5YFlbfeX5EQCZ+9M5MOVXK54lMAf16RWyuCqXWUXSLWY/NV7 r0aoKHP+1hEFs68YGx4AMc3mSkCL2CYs9EW/LeLmzlilnyaNKAQj8+hfYpojoXrFK/Nr udmcVutQBMT7HHKelXZQgx7iLGdPbitjHtjT1uVIVZtt8h0nsFBy4zrez8NLDlbm9g/h +QS3mu51eTmA60WLHK6sd5Vv+AmNffEs5QW1tirdYwwdmB7NSY7DbWfw5bfO3zk+bPUW NcBrBhGGatU9RYY9RUiQAv4n+0urEfn+baAkrDjpmPwJ5RQ7zHVNaKK7hfrFkZx1I7dZ ZCYg== X-Gm-Message-State: AGi0PuabN3xrJ4EURwHSbhRO0nfeIjbUzX9/B/N8HFlgn59YBTGkhcYC WmZU+x+fdd4QgdPt34vOlzvlzA== X-Received: by 2002:a7b:cb45:: with SMTP id v5mr4107314wmj.17.1586509921001; Fri, 10 Apr 2020 02:12:01 -0700 (PDT) Received: from [192.168.178.129] (f140230.upc-f.chello.nl. [80.56.140.230]) by smtp.gmail.com with ESMTPSA id j11sm2063686wrt.14.2020.04.10.02.11.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Apr 2020 02:12:00 -0700 (PDT) Subject: Re: [PATCH] brcmsmac: make brcms_c_set_mac() void To: Jason Yan , franky.lin@broadcom.com, hante.meuleman@broadcom.com, chi-hsien.lin@cypress.com, wright.feng@cypress.com, kvalo@codeaurora.org, davem@davemloft.net, eduardoabinader@gmail.com, christophe.jaillet@wanadoo.fr, austindh.kim@gmail.com, linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200410090817.26883-1-yanaijie@huawei.com> From: Arend Van Spriel Message-ID: <29f323a4-4749-0016-e5e5-6c17166876fc@broadcom.com> Date: Fri, 10 Apr 2020 11:11:58 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200410090817.26883-1-yanaijie@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 4/10/2020 11:08 AM, Jason Yan wrote: > Fix the following coccicheck warning: > > drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c:3773:5-8: > Unneeded variable: "err". Return "0" on line 3781 Acked-by: Arend van Spriel > Reported-by: Hulk Robot > Signed-off-by: Jason Yan > --- > drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-)