Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp3302042ybb; Mon, 13 Apr 2020 05:16:27 -0700 (PDT) X-Google-Smtp-Source: APiQypJi1+byGaQTA7FaOEbXONRuN1QZVl3+1yjcqeZ440sr1YIEKc8q93MZCMN3cCgsJIqLRv74 X-Received: by 2002:aa7:c243:: with SMTP id y3mr15542191edo.68.1586780186996; Mon, 13 Apr 2020 05:16:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586780186; cv=none; d=google.com; s=arc-20160816; b=Sm0KHZtLJr+thXFR+Cf3igxnr4mvGxli+w/LolP7M3t2yD7RiIGWYnBDlcKEnWJiYg r3a+yNAguDI+LEwLARv8FLNVLzNDATwem9VbLu8ymIC2XsJl7gvfnaw7uv1CvEY4YnCw FK4M27P1r+4QAPq5+wnBfhu+3kOBOe2xK5oUmlyRSFvzh6Z8jOud3ri+oCLEO61WYKwf mfy6bkd5kslJ+q7LhKpBKMAqtG+SpgomdMIYPI8zlHlpmCey+RZwjbb709Pz0vqDW13D I8s5RPjO6iUJlnYyQRFhT4FpiuEUdZHwhPUuD9KiyAAdxv9OZ1pGef4IQW+/HCuElat5 sRxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=cjYmgOuIWDFNvolcNnpeaU9TQCDu1pFnEMcQ/b195zM=; b=pji1vX4XZKnApq+kEGjXTu7f1yOL9nZ5wVYcJLN7d8+7oafpzK3RHPkeaa2Ey987LR KOT5agLZ78jaABxqNOXOXmoslL9OfFO4GilfMxHnQFU2EUZQx3EHSZ2dBQm9hmhbfQkB +9nOys9vuOcA3I0yjTqR6eMLeH4vJm3j7faHpe8Hz/c9IOYFfA4mFDNmbwRqQElOoKLQ +2LDXbtyMYRKpwNBCdLGUkVjOqQVUFU6l46thK91/wKhVjQPC7YI12pLZj6IAvpfLz8b 835DRLiAiJ7zgqr6S1gCpanomQUCk44Rz7aC1/G7EcDdpf7x41vSxRK1fV3YFPxEtH+W 0tDA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y4si6514034edy.398.2020.04.13.05.15.52; Mon, 13 Apr 2020 05:16:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729479AbgDMHyM (ORCPT + 99 others); Mon, 13 Apr 2020 03:54:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.18]:37348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727480AbgDMHyM (ORCPT ); Mon, 13 Apr 2020 03:54:12 -0400 Received: from huawei.com (szxga04-in.huawei.com [45.249.212.190]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5286C008651; Mon, 13 Apr 2020 00:54:11 -0700 (PDT) Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 2976A9A447D55784BA21; Mon, 13 Apr 2020 15:54:09 +0800 (CST) Received: from huawei.com (10.175.124.28) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.487.0; Mon, 13 Apr 2020 15:53:58 +0800 From: Jason Yan To: , , , , , , CC: Hulk Robot Subject: [PATCH] libertas: make lbs_process_event() void Date: Mon, 13 Apr 2020 16:20:22 +0800 Message-ID: <20200413082022.22380-1-yanaijie@huawei.com> X-Mailer: git-send-email 2.21.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.124.28] X-CFilter-Loop: Reflected Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fix the following coccicheck warning: drivers/net/wireless/marvell/libertas/cmdresp.c:225:5-8: Unneeded variable: "ret". Return "0" on line 355 Reported-by: Hulk Robot Signed-off-by: Jason Yan --- drivers/net/wireless/marvell/libertas/cmd.h | 2 +- drivers/net/wireless/marvell/libertas/cmdresp.c | 5 +---- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/marvell/libertas/cmd.h b/drivers/net/wireless/marvell/libertas/cmd.h index 80878561cb90..3c193074662b 100644 --- a/drivers/net/wireless/marvell/libertas/cmd.h +++ b/drivers/net/wireless/marvell/libertas/cmd.h @@ -76,7 +76,7 @@ void lbs_mac_event_disconnected(struct lbs_private *priv, /* Events */ -int lbs_process_event(struct lbs_private *priv, u32 event); +void lbs_process_event(struct lbs_private *priv, u32 event); /* Actual commands */ diff --git a/drivers/net/wireless/marvell/libertas/cmdresp.c b/drivers/net/wireless/marvell/libertas/cmdresp.c index b73d08381398..cb515c5584c1 100644 --- a/drivers/net/wireless/marvell/libertas/cmdresp.c +++ b/drivers/net/wireless/marvell/libertas/cmdresp.c @@ -220,9 +220,8 @@ int lbs_process_command_response(struct lbs_private *priv, u8 *data, u32 len) return ret; } -int lbs_process_event(struct lbs_private *priv, u32 event) +void lbs_process_event(struct lbs_private *priv, u32 event) { - int ret = 0; struct cmd_header cmd; switch (event) { @@ -351,6 +350,4 @@ int lbs_process_event(struct lbs_private *priv, u32 event) netdev_alert(priv->dev, "EVENT: unknown event id %d\n", event); break; } - - return ret; } -- 2.21.1