Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 62B80C4478C
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] b43legacy: Fix case where channel status is corrupted
From:   Kalle Valo <kvalo@codeaurora.org>
In-Reply-To: <20200407190043.1686-1-Larry.Finger@lwfinger.net>
References: <20200407190043.1686-1-Larry.Finger@lwfinger.net>
To:     Larry Finger <Larry.Finger@lwfinger.net>
Cc:     linux-wireless@vger.kernel.org,
        Larry Finger <Larry.Finger@lwfinger.net>,
        Stable <stable@vger.kernel.org>
User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12
Message-Id: <20200414150829.586F4C433CB@smtp.codeaurora.org>
Date:   Tue, 14 Apr 2020 15:08:29 +0000 (UTC)
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Larry Finger <Larry.Finger@lwfinger.net> wrote:

> This patch fixes commit 75388acd0cd8 ("add mac80211-based driver for
> legacy BCM43xx devices")
> 
> In https://bugzilla.kernel.org/show_bug.cgi?id=207093, a defect in
> b43legacy is reported. Upon testing, thus problem exists on PPC and
> X86 platforms, is present in the oldest kernel tested (3.2), and
> has been present in the driver since it was first added to the kernel.
> 
> The problem is a corrupted channel status received from the device.
> Both the internal card in a PowerBook G4 and the PCMCIA version
> (Broadcom BCM4306 with PCI ID 14e4:4320) have the problem. Only Rev, 2
> (revision 4 of the 802.11 core) of the chip has been tested. No other
> devices using b43legacy are available for testing.
> 
> Various sources of the problem were considered. Buffer overrun and
> other sources of corruption within the driver were rejected because
> the faulty channel status is always the same, not a random value.
> It was concluded that the faulty data is coming from the device, probably
> due to a firmware bug. As that source is not available, the driver
> must take appropriate action to recover.
> 
> At present, the driver reports the error, and them continues to process
> the bad packet. This is believed that to be a mistake, and the correct
> action is to drop the correpted packet.
> 
> Fixes: 75388acd0cd8 ("add mac80211-based driver for legacy BCM43xx devices")
> Cc: Stable <stable@vger.kernel.org>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> Reported-and-tested by: F. Erhard <erhard_f@mailbox.org>

Patch applied to wireless-drivers-next.git, thanks.

ec4d3e3a0545 b43legacy: Fix case where channel status is corrupted

-- 
https://patchwork.kernel.org/patch/11478883/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches