Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp13937ybz; Wed, 15 Apr 2020 03:30:34 -0700 (PDT) X-Google-Smtp-Source: APiQypKFMpFtI+KMR2aMpnYo2nV00nxcY5P81n6aXUL22p6SsCsQKjWBvC8bVsZLvbi4f6Yk107O X-Received: by 2002:a05:6402:3136:: with SMTP id dd22mr7094453edb.165.1586946634520; Wed, 15 Apr 2020 03:30:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586946634; cv=none; d=google.com; s=arc-20160816; b=Xn1JqxrbfXiGoNy7cq4Oj3v21pB5+U/z1NZKuszOoLDbGlOzc+Hh9PcfwFjoYjGA6h v15ZEb0GaLLxX0K2M+/A2UnmEy/pOW9ptrVTSr5MQZwWOxSCQlbAwgOjIYRxLkJnOqWC 9VUigikqs4V59mda5KjK5ON7PXxmi0J8WeHDTXCC/nXpP0+kofrKHBMO+4dedZlpnShI 0RHFZTTslODs+5MrejamUa4g7YZeRoxVsNO8tEJM5QGc2F2EC24EcWsOnsMwWORm5t4z bNYnau6rt/kLmDFowTxjoelzA0/Z465q9QCyq06ve0uAkMJBur3UtEuythBZdl4hdxN+ Z4qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:dmarc-filter :dkim-signature; bh=4FdGEmSfSLCLdc/nHt2xIO+4z1F2g07xbIFX8SpYQDo=; b=slm3AUo+LnMeWfcn2fyvab54QrKTLb87Gekj4pEl6WZequ8ouuVyJxgo2mjw4CLbx2 jxRIrGm7vf4JXkzCIA1oV8SorX5UvMKH3FNd/fPhK+kZVd0QOg2oW+RbUOUvIvsn6Vyc 7dU7q5g+aiPd6e47R0gYI1zEMZd51imqZ6D25fYAKfg8kG4k47N20Qr2frFnKCzzYuUh /2qBC9VwNef+0WKMdCNkbnadwptj1MProlvX71P6vUgHAnehY3ecehdxa8OCYauffCb/ QTm44taRyek2RbrXXY9Xf42d8XWGFXKhpWkOcbIfHVUDt5ViePMRPgeLCiA9x7i+AwEs iAhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=vC95RlcI; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g8si10960830edy.69.2020.04.15.03.29.58; Wed, 15 Apr 2020 03:30:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=vC95RlcI; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406041AbgDNGcq (ORCPT + 99 others); Tue, 14 Apr 2020 02:32:46 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:34400 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405991AbgDNGcp (ORCPT ); Tue, 14 Apr 2020 02:32:45 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1586845965; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=4FdGEmSfSLCLdc/nHt2xIO+4z1F2g07xbIFX8SpYQDo=; b=vC95RlcIbGVPbfpENarMZ6WHFUD334dvkqoZKDUhMufwp3KJMXV43HqqXZswyg5whHL4tySW E69O24uyPHGwiKZ3AnKKWiwfel5j9c2DxDxQXj/25+AVINJO4kcnmrRhCxQp2DxlOszyyVhx U4LdLKhDi150m92/qeDXWnNSn/c= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e955908.7f58d7f0fea0-smtp-out-n02; Tue, 14 Apr 2020 06:32:40 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 0D80DC432C2; Tue, 14 Apr 2020 06:32:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.0 Received: from tynnyri.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id B025DC433CB; Tue, 14 Apr 2020 06:32:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B025DC433CB Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Felix Fietkau Cc: linux-wireless@vger.kernel.org, Soul Huang Subject: Re: [PATCH] mt76: mt7615: rework IRQ handling to prepare for MSI support References: <20200409155902.58185-1-nbd@nbd.name> Date: Tue, 14 Apr 2020 09:32:36 +0300 In-Reply-To: <20200409155902.58185-1-nbd@nbd.name> (Felix Fietkau's message of "Thu, 9 Apr 2020 17:59:02 +0200") Message-ID: <87v9m2lgqj.fsf@tynnyri.adurom.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Felix Fietkau writes: > With MSI interrupts, IRQs must not be enabled from within the IRQ handler, > because that can lead to lost events. > Defer IRQ processing to a tasklet, which is also responsible for enabling > IRQs (to avoid race conditions against the handler) > > Co-developed-by: Soul Huang Soul's s-o-b is missing. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches