Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp13935ybz; Wed, 15 Apr 2020 03:30:34 -0700 (PDT) X-Google-Smtp-Source: APiQypJPeR1+yS0mOCHG/ZBv3dIbavUCXfO8AD02yNHyB2KI6Z8HsA9m7K4XtZg9cMvN/iubk2Ke X-Received: by 2002:a50:c004:: with SMTP id r4mr22995762edb.110.1586946634520; Wed, 15 Apr 2020 03:30:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586946634; cv=none; d=google.com; s=arc-20160816; b=D9lF89WMHtBJ5nDt4vqHCMRgvGDdOcCnye0PdNz6m6Hjkpac0SRbI0O+RteINzV6MC 5evtfJiokCdjlKPLhl+4nS5fH7qpsJQXNB0KyZhb9HAbxJ4ue3fpCDrQhb4T7ra7h8Wo RfLrU//P7B6MTKuk/s1t8dIf/bnoYGiaNtq4UWDgu7484gAq3ngXRseKBhM4ZjaAG5EZ 3x441pINpQM0CSM+X3Hp9Gobq14JfEXVo+0ZfEzIviLtKqKjzdM2Ur3gVf3H4MQPRuPR udx+pzlh/mfE/v75tHep01m8Tayeh+OKGTpezRN13pDf11F1w2bUbU5ADh4Ept+z+51w 6eZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:dmarc-filter :dkim-signature; bh=T7OoWyEzPwXRazzh9XBTXC4jr6oq9UVyd5x0NpZXrK4=; b=Y5XMECmyPF12t6R2+S4/Ju8LpT0r47dosXLIJeFaITJIh6wpWzWh6gDY0c9VxLw67A mILUewxnc1QUgVy0kOjCqwCg/RsVEIiL99xV+01Fil3B1GHdvTBt4BuEfIKBag4Jtiuy qSRr112yE/CDtuF0LtPeYVh+/sVYCOuVCQChaF1UkarxmPdoqBVi9vt4tvun/IQrVo5A TKdlIBs3Jn5yS70JSZXa8mER2m9k6ayNGXPn6F3khxW1lYVOeVM+DjUpwyQ3ORjFaloF 63iQXHEj2gdfgBcQZX0VQwOJQNUUU1r83oI1P5TXu9vFC/fh0RjvH+r2GwEjvQ3rfgXB X4Dg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=DBBAzz+9; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v22si377059eds.78.2020.04.15.03.30.05; Wed, 15 Apr 2020 03:30:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=DBBAzz+9; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406043AbgDNGeT (ORCPT + 99 others); Tue, 14 Apr 2020 02:34:19 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:34400 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2406042AbgDNGeS (ORCPT ); Tue, 14 Apr 2020 02:34:18 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1586846057; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=T7OoWyEzPwXRazzh9XBTXC4jr6oq9UVyd5x0NpZXrK4=; b=DBBAzz+9AXC5H7FkvQn/oHaE5XoIuUzViWiHMU5F6xVHU2pt5qBZ5PzemkUDndhl81SpJCb7 F2fgRR56xydxHFmwGIA9AtII3INKv7m4fOJHFbpuyOZ8fMxzEXjhKuA4GaFyIlEdzyNIkI4d RYTRm7GQ2gg5+dZBjtpq3r/Gu/U= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e955964.7f7bbc824260-smtp-out-n01; Tue, 14 Apr 2020 06:34:12 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 1996BC43637; Tue, 14 Apr 2020 06:34:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.0 Received: from tynnyri.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 94148C433CB; Tue, 14 Apr 2020 06:34:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 94148C433CB Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Felix Fietkau Cc: linux-wireless@vger.kernel.org, Soul Huang , Lorenzo Bianconi Subject: Re: [PATCH v2] mt76: mt7615: rework IRQ handling to prepare for MSI support References: <20200409181401.12070-1-nbd@nbd.name> Date: Tue, 14 Apr 2020 09:34:09 +0300 In-Reply-To: <20200409181401.12070-1-nbd@nbd.name> (Felix Fietkau's message of "Thu, 9 Apr 2020 20:14:01 +0200") Message-ID: <87r1wqlgny.fsf@tynnyri.adurom.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Felix Fietkau writes: > With MSI interrupts, IRQs must not be enabled from within the IRQ handler, > because that can lead to lost events. > Defer IRQ processing to a tasklet, which is also responsible for enabling > IRQs (to avoid race conditions against the handler) > > Co-developed-by: Soul Huang > Acked-by: Lorenzo Bianconi > Signed-off-by: Felix Fietkau Soul's s-o-b is missing. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches