Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org C927BC433BA
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Stephen Rothwell <sfr@canb.auug.org.au>
Cc:     Larry Finger <Larry.Finger@lwfinger.net>,
        Wireless <linux-wireless@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the wireless-drivers-next tree
References: <20200415080827.30c2c9c1@canb.auug.org.au>
        <5b17fefe-f99d-2e4c-ded2-93fd3554687c@lwfinger.net>
        <20200415110649.39e26be3@canb.auug.org.au>
Date:   Wed, 15 Apr 2020 07:45:06 +0300
In-Reply-To: <20200415110649.39e26be3@canb.auug.org.au> (Stephen Rothwell's
        message of "Wed, 15 Apr 2020 11:06:49 +1000")
Message-ID: <87tv1ls6gd.fsf@kamboji.qca.qualcomm.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Stephen Rothwell <sfr@canb.auug.org.au> writes:

> Hi Larry,
>
> On Tue, 14 Apr 2020 19:36:28 -0500 Larry Finger <Larry.Finger@lwfinger.net> wrote:
>>
>> On 4/14/20 5:08 PM, Stephen Rothwell wrote:
>> > 
>> > In commit
>> > 
>> >    ec4d3e3a0545 ("b43legacy: Fix case where channel status is corrupted")
>> > 
>> > Fixes tag
>> > 
>> >    Fixes: 75388acd0cd8 ("add mac80211-based driver for legacy BCM43xx devices")
>> > 
>> > has these problem(s):
>> > 
>> >    - Subject does not match target commit subject
>> >      Just use
>> > 	git log -1 --format='Fixes: %h ("%s")'
>> 
>> I do not understand what you want here. The subject describes what was fixed. 
>> The error has been in the driver since it was merged. The Fixes: line is a 
>> description of the commit that introduced the driver file with the error.
>
> The subject I was referring to is the subject quoted in the Fixes tag,
> not the subject of the fixing commit.  So:
>
> Fixes: 75388acd0cd8 ("[B43LEGACY]: add mac80211-based driver for
> legacy BCM43xx devices")
>
> Its not very important, just a consistency thing - I wouldn't bother
> rebasing just to fix this, just for the future ...

Yeah, I don't normally rebase wireless-drivers-next so this has to be
like this. But hopefully some time in the future I'll end up adding a
check for this in my patchwork script.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches