Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp589839ybz; Wed, 15 Apr 2020 14:40:24 -0700 (PDT) X-Google-Smtp-Source: APiQypKLu1I8PfW3knmmzd9C6U6V9086wsmsuyUltapiFx84qiHL5fGywSPm2UVXTnaN97FO4WAD X-Received: by 2002:a17:906:7045:: with SMTP id r5mr7009164ejj.29.1586986824390; Wed, 15 Apr 2020 14:40:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586986824; cv=none; d=google.com; s=arc-20160816; b=RgNK+NGdAx0T9STJOcwCE2b3PgFOAgoE/YsDStUSUGZB8r9zyPqiA3l9xBbvBb59eC TCkNrVk6QUB/Mvt9ktEAMFzgMRPFx2vyqGWqz8FcyWMkBYYjdICUDdHU9Nyjse7btfba MmLjZm7xDb4LYm4D/fv+n+sI2vp57nGX/VEQlbWagqEaHStDAz4BnjUEL/KBCtadOeCD xkgiIwhh02KEebqhO5L6tDDchR/IPs+ghC/PMJ6dOWG+1TUmPuejfmj/jF5q0qzPljjK 85EK7QMcoLoPsH5yUWhavuIke43CFYz9t7ue0+oqCjSMD98ZkFhGcyeokXK23QTLfwyS Epag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature; bh=pzkx7xJD1kBHfGD+u6PRwl7F+O1g7GJzrEjUCdwfk/E=; b=EL2yBUzLpxI5qv32T54DKgJD5fax0w6MzthtFK3ER2tG+RqMQDntqmPFbI5uauQfEQ cMANWHJkvhne0BvHZo5xC/rDpKHs9MDaLWntKUFDAz79STQOhc3U5ESE5aJesMMo8gqb URl+SJnl3fE4Byq8Td+ai5YjKODjpOb+xYyZLBW7tzYewkeOqBK1bppExiXp5mVDNuMC ZH1Yihn9wDnmsvzSnxKuTdqtY4F3pKjIAeLmsngy0fitlN1j5fJNOKPFGIwVh9nT6Y3C C31ULPeG0Ns69Wey28BjWKCs/m6W47rIjb0WjHoE/b3LJ1DN61+S3Fr8+0tnE8Y3gByk 5kFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=O1lUFHas; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ga21si10650044ejb.350.2020.04.15.14.40.01; Wed, 15 Apr 2020 14:40:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=O1lUFHas; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2436702AbgDNPHe (ORCPT + 99 others); Tue, 14 Apr 2020 11:07:34 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:20387 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2440187AbgDNPHa (ORCPT ); Tue, 14 Apr 2020 11:07:30 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1586876849; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=pzkx7xJD1kBHfGD+u6PRwl7F+O1g7GJzrEjUCdwfk/E=; b=O1lUFHasdYbVPOEo1sz0abqD3+b9+sqfvkWXiIkW37j25iVQ9APzjoCCqQGVW98mGrWcw0JH q6hmHsISKbGnyO4vw0CA4DKEnh4+9Nu2wCI5RqUUghSJrl7X5+nlzwfqnyRyq9cArdEJilnC NaFPlz3uooHT/SznAajVgNE0hsY= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e95d1b0.7f7bb752a650-smtp-out-n01; Tue, 14 Apr 2020 15:07:28 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id D6DA0C4478C; Tue, 14 Apr 2020 15:07:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.5 required=2.0 tests=ALL_TRUSTED,MISSING_DATE, MISSING_MID,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id A6BEFC433CB; Tue, 14 Apr 2020 15:07:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A6BEFC433CB Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2] rtw88: Add delay on polling h2c command status bit From: Kalle Valo In-Reply-To: <20200407073331.397-1-kai.heng.feng@canonical.com> References: <20200407073331.397-1-kai.heng.feng@canonical.com> To: Kai-Heng Feng Cc: yhchuang@realtek.com, Kai-Heng Feng , "David S. Miller" , linux-wireless@vger.kernel.org (open list:REALTEK WIRELESS DRIVER (rtw88)), netdev@vger.kernel.org (open list:NETWORKING DRIVERS), linux-kernel@vger.kernel.org (open list) User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20200414150728.D6DA0C4478C@smtp.codeaurora.org> Date: Tue, 14 Apr 2020 15:07:28 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Kai-Heng Feng wrote: > On some systems we can constanly see rtw88 complains: > [39584.721375] rtw_pci 0000:03:00.0: failed to send h2c command > > Increase interval of each check to wait the status bit really changed. > > Use read_poll_timeout() macro which fits anything we need here. > > Suggested-by: Kalle Valo > Signed-off-by: Kai-Heng Feng Patch applied to wireless-drivers-next.git, thanks. 6343a6d4b213 rtw88: Add delay on polling h2c command status bit -- https://patchwork.kernel.org/patch/11477667/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches