Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp637053ybz; Wed, 15 Apr 2020 15:39:38 -0700 (PDT) X-Google-Smtp-Source: APiQypL3JJHCEg5ihRCjBZe+hBk8Bhw1biFu0LfmF8tkwaJZJURmHOvFC5JCxatg1u4bwBgTP9kn X-Received: by 2002:a17:907:435d:: with SMTP id oc21mr7360645ejb.100.1586990378662; Wed, 15 Apr 2020 15:39:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586990378; cv=none; d=google.com; s=arc-20160816; b=PEqOOu0iYNP9QWbECKUjDTek47bBboOpf+IJFp9ppg15RwxUGY6IevklTBqxAoJjnh aH5Yl7C3lEeyOz+fCmBBSWmerQbqvtlKGC+OcjAePk1+aLMCJykxMI1V6FxJoPEwtwyH G8dX3G655wjR1Mxg+2tWmJMT9uQ+o9Ga58XVGXGEgqouXgdgC3AB4hiC1niwqIZ8NCfz L1NgRSZQr60nTJVhHcURRAdlGfBw/oB8vmngu/+lzlAgyCLrBE+bSaMiC0poDTudO0xB A09EglIjNMRceQrKm+CLTY5+a8N7irlZVEyTh4DY6PfglH4gH5l50YcfHJWvlKQKGO2/ nICg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature; bh=LLHAtAIAM78mFzS4R6StWkJhZeeVtwmJ8k6NH2UzjUQ=; b=0QYz/lR3Mq9lhkNE8sjL0CKnOkw2jyQK54cmFRnFrYwGAVAP+MwySiJu7K8kKC6kF8 xhLBXEmkHoSQhOh9F6tv9+IUHky5ymSAjL/82oLcbvgN6EEqh/SSXO0fXT9VZVfnSLMj XFDFcQeW1v43QkaqSOzptWx7wiYmieiH7fBsUR1XzNqSjNj51DxD557T1jUfA1KVNNpI nwSrfqXOH2Vbf3zN9Ppfv3tJTaiefRHiXFVNZPtjaNJ0ql2wcFNod/NI61YWjSNStBIt ya8sh+nvYJYoldbDJ2K3rU5FPYwxRhQAFaJ3eBpJBtdxMfTEBxTQas5iOz39Uy8VcPlK seVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=cu6624mL; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b89si2568216edf.345.2020.04.15.15.39.15; Wed, 15 Apr 2020 15:39:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=cu6624mL; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2894937AbgDOIpc (ORCPT + 99 others); Wed, 15 Apr 2020 04:45:32 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:53170 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2894935AbgDOIp0 (ORCPT ); Wed, 15 Apr 2020 04:45:26 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1586940324; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=LLHAtAIAM78mFzS4R6StWkJhZeeVtwmJ8k6NH2UzjUQ=; b=cu6624mL/OUXVbt8/rbBKjhgdZz02HNLoEvndAtUydO4mFVuM66aS1uXA/TYhchxo2R2IhGS V6FGp4GYZ5cE9ZvMTpGntWf9LSiWH9sLhDK7lNXCH143IQlW0pQJM2jpaZlRTDBEBBuynqlH LAU5cojDKd6yiXW8FD/J62CriF8= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e96c993.7f622155a650-smtp-out-n01; Wed, 15 Apr 2020 08:45:07 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 6D00FC433BA; Wed, 15 Apr 2020 08:45:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.5 required=2.0 tests=ALL_TRUSTED,MISSING_DATE, MISSING_MID,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 5264DC433CB; Wed, 15 Apr 2020 08:45:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 5264DC433CB Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH 5/9] brcmsmac: Add missing annotation for brcms_down() From: Kalle Valo In-Reply-To: <20200411001933.10072-6-jbi.octave@gmail.com> References: <20200411001933.10072-6-jbi.octave@gmail.com> To: Jules Irenge Cc: linux-kernel@vger.kernel.org, boqun.feng@gmail.com, Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , "David S. Miller" , Johannes Berg , linux-wireless@vger.kernel.org (open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER), brcm80211-dev-list.pdl@broadcom.com (open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER), brcm80211-dev-list@cypress.com (open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER), netdev@vger.kernel.org (open list:NETWORKING DRIVERS) User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20200415084507.6D00FC433BA@smtp.codeaurora.org> Date: Wed, 15 Apr 2020 08:45:07 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Jules Irenge wrote: > Sparse reports a warning at brcms_down() > > warning: context imbalance in brcms_down() > - unexpected unlock > The root cause is the missing annotation at brcms_down() > Add the missing __must_hold(&wl->lock) annotation > > Signed-off-by: Jules Irenge Patch applied to wireless-drivers-next.git, thanks. 40fb232c02d1 brcmsmac: Add missing annotation for brcms_down() -- https://patchwork.kernel.org/patch/11483851/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches