Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Fri, 17 Apr 2020 12:32:09 +0800
From:   Wen Gong <wgong@codeaurora.org>
To:     Kalle Valo <kvalo@codeaurora.org>
Cc:     ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath10k: improve power save performance for sdio
In-Reply-To: <877dyfr4fb.fsf@kamboji.qca.qualcomm.com>
References: <0101016ed9241282-73dd8b35-e2e5-4f37-9b50-cf2fb6524dfc-000000@us-west-2.amazonses.com>
 <877dyfr4fb.fsf@kamboji.qca.qualcomm.com>
Message-ID: <b9f680d57a6fbc9ac59dc5fc281d0af3@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 2020-04-16 20:38, Kalle Valo wrote:
> Wen Gong <wgong@codeaurora.org> writes:
> 

> 
>> +static inline int ath10k_hif_set_mbox_sleep(struct ath10k *ar, bool 
>> enable_sleep)
>> +{
>> +	if (ar->hif.ops->set_mbox_sleep)
>> +		return ar->hif.ops->set_mbox_sleep(ar, enable_sleep);
>> +	return 0;
>> +}
> 
> I don't think we need to add another hif op for this. I sent v2 which
> uses existing op.
Yes, I see it.
but I see it removed ath10k_hif_set_mbox_sleep in ath10k_core_start,
expected it will not effect the patch's power save.