Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 71443C433BA
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Sedat Dilek <sedat.dilek@gmail.com>
Cc:     Johannes Berg <johannes.berg@intel.com>,
        Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
        Luca Coelho <luciano.coelho@intel.com>,
        Intel Linux Wireless <linuxwifi@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Chris Rorvick <chris@rorvick.com>
Subject: Re: [PATCH wireless-drivers v3] iwlwifi: actually check allocated conf_tlv pointer
References: <20200417074558.12316-1-sedat.dilek@gmail.com>
Date:   Fri, 17 Apr 2020 11:03:03 +0300
In-Reply-To: <20200417074558.12316-1-sedat.dilek@gmail.com> (Sedat Dilek's
        message of "Fri, 17 Apr 2020 09:45:58 +0200")
Message-ID: <87pnc6pmiw.fsf@kamboji.qca.qualcomm.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Sedat Dilek <sedat.dilek@gmail.com> writes:

> From: Chris Rorvick <chris@rorvick.com>
>
> Commit 71bc0334a637 ("iwlwifi: check allocated pointer when allocating
> conf_tlvs") attempted to fix a typoe introduced by commit 17b809c9b22e
> ("iwlwifi: dbg: move debug data to a struct") but does not implement the
> check correctly.
>
> Fixes: 71bc0334a637 ("iwlwifi: check allocated pointer when allocating conf_tlvs")
> Tweeted-by: @grsecurity
> Message-Id: <20200402050219.4842-1-chris@rorvick.com>
> Signed-off-by: Chris Rorvick <chris@rorvick.com>
> Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>

Thanks, looks good to me. I'll just remove the Message-Id tag, it's not
really needed in this case.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches