Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp4035628ybz; Mon, 20 Apr 2020 14:20:10 -0700 (PDT) X-Google-Smtp-Source: APiQypLxX4RZCeKhC+hFf1CWTKktb1FsZXz1+X+alE2orG1w2F/FkiCjbT27/uywhT/g1RWLL6wi X-Received: by 2002:a05:6402:22a6:: with SMTP id cx6mr12171515edb.277.1587417610574; Mon, 20 Apr 2020 14:20:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587417610; cv=none; d=google.com; s=arc-20160816; b=nvr8LPgLrGYMq69A22qaq1n4eIHis9BV4XrfhuTeZHB5iKuNiYgVFpsqozFCgq2Uxd CiJxkXKusaagU8GtGTFbdNec0nu+S4fTW8HfzmXIw6jR8H4hx+c0IIyv3oyjCM1h0jO1 ZXIrTdhVH4mivCmxR0tZoB+rpdGhaIo7ajhPkEDxRyGava2x6YsVA0mElHRTbDfX/IEa qBKj68JD7dfwbF1hx33e7Wm0TvVb56nz0nrXSzxoR6ULmfOlxJSTkgo/RK1ClzDqC7lF 6x9hNPmJ2SAMBjMiK/KNaskwKJAhHnuup7lt8gzT0sQ+wxGkbm1dVaOdZAYq+wTWmrJZ GHrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=+rrcChUIIIEzyTsU2WS1MoX2JhcoGiCi0fSrrndWgF0=; b=SVulRXBdgk1krYGzoR5AMDrOh8E7z9sDrovE+/Axx2582NXlmLovWbXiRTk7KlVNYO TT5I97gXs9GArSb3RcfTd4XbhAJOHX56lHY1Or1VoqH/GtTBKCInBFiKqEL6CtHG7Owz Ed8VQH6225GuRaGvv1ZWqTPNfxJjyPO+edlwiXVax0Tvkd4ZBuZG5b0o+yXPb/nQ1Lsr FQbbMtji1fs0i6DR/69tMjejESHV42p4wD/L66wcfUE1u36UZU6YBVx8A6FwLUKPTHz0 S9hYbz5BZvxiMoQ6MQJzBoUt4Ycq4ZTmlpsKugtaKFcrxm+D8rA2EUfvzIopkyRdISaL y7lg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id nm1si245276ejb.451.2020.04.20.14.19.35; Mon, 20 Apr 2020 14:20:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727792AbgDTVSn (ORCPT + 99 others); Mon, 20 Apr 2020 17:18:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726021AbgDTVSm (ORCPT ); Mon, 20 Apr 2020 17:18:42 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6BDDDC061A0C for ; Mon, 20 Apr 2020 14:18:42 -0700 (PDT) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.93) (envelope-from ) id 1jQdoN-00CxS6-J3; Mon, 20 Apr 2020 23:18:39 +0200 Message-ID: <7b629e3d1aac2057c37ecc207e7154c3a0bd891b.camel@sipsolutions.net> Subject: Re: [RFC] mac80211: Process multicast RX registration for Public Action frames From: Johannes Berg To: Jouni Malinen Cc: linux-wireless@vger.kernel.org Date: Mon, 20 Apr 2020 23:18:38 +0200 In-Reply-To: <20200420205055.15573-1-jouni@codeaurora.org> References: <20200420205055.15573-1-jouni@codeaurora.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon, 2020-04-20 at 23:50 +0300, Jouni Malinen wrote: > > + * @rx_multicast_reg: multicast Public Action frames should be reported to > + * mac80211 for this interface. Since this is pretty specific ("multicast Public Action"), ... > + local->rx_multicast_reg = upd->global_mcast_stypes; Maybe that should be a bit more specific and select only action subtype? I guess I'd kinda prefer to document action, not just public action too, since that's the granularity we have in the API now? I mean, public action may be all we need now, but ... johannes