Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp4468714ybz; Tue, 21 Apr 2020 00:53:37 -0700 (PDT) X-Google-Smtp-Source: APiQypJpaZ4BkTUcdp44VIqTgkYJHEO00tYQu7W8TA/DOvI4Xq6pWfePR6lbYfjG6/vz7hMvqQmo X-Received: by 2002:a17:907:2069:: with SMTP id qp9mr20373824ejb.137.1587455616860; Tue, 21 Apr 2020 00:53:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587455616; cv=none; d=google.com; s=arc-20160816; b=can+/PKpVh679j8BSIECRbUV90GXmAQkADKJengw2GQFtePiScIyOmoWcZ2kR9DgNt T5bZoNIsLNW7w74pb6MqdI1on/e4olt2yhngL5HIE6stGbRj/pbuFluyloi6k2tKwgs6 Vb7wOPJLQ3L08cQ/AC0dVBby9D1r9cxBZcIlGfEdOopCROBTZVugpItWpTlTQgKgn7FM ChqcYwOZUoKZlI1+xsLZ8X4fEcaoAHIJ7MEeqACfDJiChMAy+pnTeG3H3CP4a09lB+AW DQTf1ELHxyfjeR6m995fsJhGrKbAwh07y0gYYCo1WV9Cjb777dD7REUk17t+wp7DjxJZ Y6eQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature; bh=kst1zyO2lCjRLxmPkLZYJ0AM8pU8DebCRu7H17+CtE0=; b=kX60dxNnrn3+hdKPqpv8QmJk+V/k8rfVdyrstwTsDfVi0NKF2QdLbCV9WEo3OA3Xu7 AC4UNJMyBb9PJuvd7auWoI6smvIY1DMgux4uJL9qcItcs2+ZybHuvxzypjc61IOBGdvF tOb4eh08DGKQxJ8PQ8EA2f20AEvaSh/xqyAY4yUZgxOhzn2ZWz+oaAkQy4/7+ZX68XgD VzAT3yB23FGFImov00pXZqMPs+rJlPFcmACfXksmtlVGRA58Eh4KshPv92pntbwBzWqY 3aOGtIqhOHUEOAZdZHNKiMTlZeDZG2DmeLcN/zrYggrys6StaDZ1gmJq97RQOjDk6bE0 BDZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=p5DDgu6l; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p4si996135ejr.353.2020.04.21.00.53.05; Tue, 21 Apr 2020 00:53:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=p5DDgu6l; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726106AbgDUHuc (ORCPT + 99 others); Tue, 21 Apr 2020 03:50:32 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:27396 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726013AbgDUHuc (ORCPT ); Tue, 21 Apr 2020 03:50:32 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1587455431; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=kst1zyO2lCjRLxmPkLZYJ0AM8pU8DebCRu7H17+CtE0=; b=p5DDgu6lofezAuAkcM6izbqvuwvsSxhrXwvjSIMQWsAZKuHepCN/HEpaderSe6lU8iwhN/8S 5gjOjz4CvQPBp3P4UeVg7uMxSNF+zaeWiLGLoOY2d2kBXFJxg9+feh8rj4uOR5KdSe5cdDIT Gk43eJ1N85NeIhxUzXQD50km5b8= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e9ea5c7.7f6ee29ba538-smtp-out-n02; Tue, 21 Apr 2020 07:50:31 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id E9F6AC433BA; Tue, 21 Apr 2020 07:50:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.5 required=2.0 tests=ALL_TRUSTED,MISSING_DATE, MISSING_MID,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 054C3C433CB; Tue, 21 Apr 2020 07:50:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 054C3C433CB Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH wireless-drivers v3] iwlwifi: actually check allocated conf_tlv pointer From: Kalle Valo In-Reply-To: <20200417074558.12316-1-sedat.dilek@gmail.com> References: <20200417074558.12316-1-sedat.dilek@gmail.com> To: Sedat Dilek Cc: Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless , "David S. Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Chris Rorvick , Sedat Dilek User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20200421075030.E9F6AC433BA@smtp.codeaurora.org> Date: Tue, 21 Apr 2020 07:50:30 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Sedat Dilek wrote: > From: Chris Rorvick > > Commit 71bc0334a637 ("iwlwifi: check allocated pointer when allocating > conf_tlvs") attempted to fix a typoe introduced by commit 17b809c9b22e > ("iwlwifi: dbg: move debug data to a struct") but does not implement the > check correctly. > > Fixes: 71bc0334a637 ("iwlwifi: check allocated pointer when allocating conf_tlvs") > Tweeted-by: @grsecurity > Signed-off-by: Chris Rorvick > Signed-off-by: Sedat Dilek Patch applied to wireless-drivers.git, thanks. a176e114ace4 iwlwifi: actually check allocated conf_tlv pointer -- https://patchwork.kernel.org/patch/11494331/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches