Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp58618ybz; Tue, 21 Apr 2020 04:43:10 -0700 (PDT) X-Google-Smtp-Source: APiQypILyp9bQJPIC2bh2k5luNLXfzt9zjWeAfmFWr/OsTFWrJCaBN4d+8Kpb8ZY2ple3j326ntH X-Received: by 2002:a50:f699:: with SMTP id d25mr18211743edn.244.1587469390113; Tue, 21 Apr 2020 04:43:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587469390; cv=none; d=google.com; s=arc-20160816; b=O1orKr/Jm0W2dh8mZs3x2guWp9R+zEiZ6M3LbHtRaaDA39ae7nu8y5rz5SYIrB6yDO cPvkq9OQsokpyxM8mMCSveyVGFTMU1gEEtzLBbu+qWYjK8+XAY4W7PNBj6bSwlzI+Tgo 0Vd75OAEJJjgTxBkIyoRv0OQ6zXjzdFO04idNdEDB8WuNAjOeKOU8vCFpSH8Hg6nd27O SseGGgS3zaf7TmJZrLWEz23lzNwBg+DFP8hcyKIR5gSnpgZkVsV1ZLUYr1NehZy8REHX J0GA4tsD1shwW60a69OixoVfzygmOkMOK1ZOYn06Jqv/Va1aJtw3muRisT8Unvu+ews2 rCUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:dmarc-filter :dkim-signature; bh=MHYJbNz6ipw5UNrRMw20t/cPhwMrWUiOngdnmW95rQ4=; b=WcCl7jXZtwO/5lWh2+t413Y9mjOeWWovXrbqj4Ho4NK9ewYkdsoBbCPbS+QbSNztTC VyRGHLNTmC1lcCTOp7lN39HE/cPS5pj1b4Bk3RCygpGaOSdn/TxVs9wdyxWjL0AWW/St X0oYw/4O3dExYmGJCPDCEyzHKxRk/i/Kfd9iqglip07Yk3bEFwoLVMNN6UGwOmt5U+pz zXOSj+/BKsFYrIG2+8xq9BlUqCbwv4GFxOiMKOrOhwp5Ff56c1fn76/ynIvRNQJlebmF urhhTkiKIi1w+4n1ZB/qsIBIS/ZRubr89urhBuc09uq2DlRUtX7W1wSh53jgGRWNk5/x ebxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=Usj9zhvh; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q4si1439137eji.14.2020.04.21.04.42.35; Tue, 21 Apr 2020 04:43:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=Usj9zhvh; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727120AbgDULj1 (ORCPT + 99 others); Tue, 21 Apr 2020 07:39:27 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:58912 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726691AbgDULj1 (ORCPT ); Tue, 21 Apr 2020 07:39:27 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1587469166; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=MHYJbNz6ipw5UNrRMw20t/cPhwMrWUiOngdnmW95rQ4=; b=Usj9zhvhYt6cARAxRTCFLRyDeyLC3HGNLPcj/sY7HFWNm10dt0ryZTtdTxW6g7oHcYsqr5i4 YSeDPdd/pF0UpLMqNMKXZud/UNC5r+fYUQYiWH9D1AIi6MJ4lH4E8TvZUStW9Fa5Ycnbqgz1 xZraxbJOnN+j8Qx/rtXc9EFowbM= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e9edb6e.7f3ea97437d8-smtp-out-n04; Tue, 21 Apr 2020 11:39:26 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 1BD05C433CB; Tue, 21 Apr 2020 11:39:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id D90EDC433D2; Tue, 21 Apr 2020 11:39:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D90EDC433D2 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Raz Bouganim Cc: , Subject: Re: [PATCH v2] wlcore: Adding suppoprt for IGTK key in wlcore driver References: <1587461946-31727-1-git-send-email-r-bouganim@ti.com> Date: Tue, 21 Apr 2020 14:39:20 +0300 In-Reply-To: <1587461946-31727-1-git-send-email-r-bouganim@ti.com> (Raz Bouganim's message of "Tue, 21 Apr 2020 12:39:06 +0300") Message-ID: <875zdtoyon.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Raz Bouganim writes: > This patch adding support for new cipher suite - AES-CMAC in wlcore driver. > This patch is required for support PMF/WPA3 connection to install IGTK key. > > Signed-off-by: Raz Bouganim > --- > drivers/net/wireless/ti/wlcore/cmd.h | 1 + > drivers/net/wireless/ti/wlcore/main.c | 4 ++++ > 2 files changed, 5 insertions(+) > > diff --git a/drivers/net/wireless/ti/wlcore/cmd.h b/drivers/net/wireless/ti/wlcore/cmd.h > index f2609d5..1d14bd1 100644 > --- a/drivers/net/wireless/ti/wlcore/cmd.h > +++ b/drivers/net/wireless/ti/wlcore/cmd.h > @@ -458,6 +458,7 @@ enum wl1271_cmd_key_type { > KEY_TKIP = 2, > KEY_AES = 3, > KEY_GEM = 4, > +KEY_IGTK = 5, > }; The indentation is still all broken up, look at the end result: enum wl1271_cmd_key_type { KEY_NONE = 0, KEY_WEP = 1, KEY_TKIP = 2, KEY_AES = 3, KEY_GEM = 4, KEY_IGTK = 5, }; Can someone help Raz with this? -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches