Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 6BB85C433D2
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH v2 v5.7 1/6] iwlwifi: pcie: actually release queue memory in
 TVQM
From:   Kalle Valo <kvalo@codeaurora.org>
In-Reply-To: <iwlwifi.20200417100405.f5f4c4193ec1.Id5feebc9b4318041913a9c89fc1378bb5454292c@changeid>
References: <iwlwifi.20200417100405.f5f4c4193ec1.Id5feebc9b4318041913a9c89fc1378bb5454292c@changeid>
To:     Luca Coelho <luca@coelho.fi>
Cc:     linux-wireless@vger.kernel.org
User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2
Message-Id: <20200421124002.81361C43636@smtp.codeaurora.org>
Date:   Tue, 21 Apr 2020 12:40:02 +0000 (UTC)
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Luca Coelho <luca@coelho.fi> wrote:

> From: Johannes Berg <johannes.berg@intel.com>
> 
> The iwl_trans_pcie_dyn_txq_free() function only releases the frames
> that may be left on the queue by calling iwl_pcie_gen2_txq_unmap(),
> but doesn't actually free the DMA ring or byte-count tables for the
> queue. This leads to pretty large memory leaks (at least before my
> queue size improvements), in particular in monitor/sniffer mode on
> channel hopping since this happens on every channel change.
> 
> This was also now more evident after the move to a DMA pool for the
> byte count tables, showing messages such as
> 
>   BUG iwlwifi:bc (...): Objects remaining in iwlwifi:bc on __kmem_cache_shutdown()
> 
> This fixes https://bugzilla.kernel.org/show_bug.cgi?id=206811.
> 
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> Fixes: 6b35ff91572f ("iwlwifi: pcie: introduce a000 TX queues management")
> Cc: stable@vger.kernel.org # v4.14+
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>

6 patches applied to wireless-drivers.git, thanks.

b98b33d5560a iwlwifi: pcie: actually release queue memory in TVQM
290d5e495183 iwlwifi: mvm: beacon statistics shouldn't go backwards
d8d663970234 iwlwifi: pcie: indicate correct RB size to device
e5b72e3bc476 iwlwifi: mvm: limit maximum queue appropriately
38af8d5a90a8 iwlwifi: mvm: Do not declare support for ACK Enabled Aggregation
e6d419f94331 iwlwifi: mvm: fix inactive TID removal return value usage

-- 
https://patchwork.kernel.org/patch/11494275/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches