Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 8044FC433BA
From:   Kalle Valo <kvalo@codeaurora.org>
To:     <yhchuang@realtek.com>
Cc:     <kvalo@codeaurora.org>, <pkshih@realtek.com>,
        <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2 8/8] rtw88: 8723d: Add read_efuse to recognize efuse info from map
References: <20200420055054.14592-1-yhchuang@realtek.com>
        <20200420055054.14592-9-yhchuang@realtek.com>
Date:   Tue, 21 Apr 2020 15:56:41 +0300
In-Reply-To: <20200420055054.14592-9-yhchuang@realtek.com> (yhchuang's message
        of "Mon, 20 Apr 2020 13:50:54 +0800")
Message-ID: <87lfmpj8ty.fsf@tynnyri.adurom.net>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

<yhchuang@realtek.com> writes:

> From: Ping-Ke Shih <pkshih@realtek.com>
>
> The logical efuse map is decoded from physical map by parsing the
> header format of the physical map. And each different type of chips
> has different logical efuse layout. So add the logical map's layout
> for parsing the efuse contents.
>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
> Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>

[...]

> +static void rtw8723de_efuse_parsing(struct rtw_efuse *efuse,
> +				    struct rtw8723d_efuse *map)
> +{
> +	ether_addr_copy(efuse->addr, map->e.mac_addr);
> +}

Feels like an unnecessary extra function to me. But not a big deal, no
need to resend because of this.

And thanks for splitting the patches, makes my life a lot more pleasant :)

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches