Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp500832ybz; Tue, 21 Apr 2020 13:15:24 -0700 (PDT) X-Google-Smtp-Source: APiQypKV3P/zAJ49szyDutd51yEOCIOdfFUW0t9Ph2Uyg30YQxa4hCnh9VuON1gUz5lS9uQiXElk X-Received: by 2002:aa7:df0a:: with SMTP id c10mr19751616edy.306.1587500124762; Tue, 21 Apr 2020 13:15:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587500124; cv=none; d=google.com; s=arc-20160816; b=iA9GWafADocwZMdDrJ5vUMslnUmrpmG/8hx+Hvzooj5pGpZoNMaVOMOcMOBBs+Cvtb h6FAJmftqbHNz92u2SFs/6sdvYhWY2AlJjnFeSXnDFewPwYCOXoN8U4YVg7M4iiOYhft 10OEaCGaL5KUdZp3CAasBDpyrSD378Khuzce/0/+vQvvGfbK3GIxte/TrR8wboXy5+T0 y5jTbFAgZaeFT1Edry3BhUhw7x8nr3LrPuzjlx7qEVG8SfIUNUHDIxUryRgRzvsgUcnj e1WqiLMYUcoKiWW9ynfUdgqr2rdWDGoTMKY4dEhzi5MjZMjezBZbcYRWaBeNx9r3h/P2 jI2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:content-transfer-encoding :mime-version:user-agent:references:in-reply-to:date:cc:to:from :message-id; bh=0/YH04oq2fIqKUGy2TEwD/Cl3yZYG5agZ7r+PklUC/Y=; b=doRQzxLzyW0JPNPUkym4ZNFoePGpXKwH18Bso7jeRBlsKFEBhHCYpJZ0ts9oW8UVEB tpBzs/Yei1mmL/sxl85LVXcra1yLd8Qie5DXNMZH6FBNZkSVkXn7LeSCgMwwqhs/Uakz zUkgE5C7c/IKBNw8Ml4VifUKCImKx/KgEPc6dbrOd6KBbKiDa/9ncrfXaybfTFCvQBOd X1DT2zTCaAafBE0oKrYJWVWYRIcH+RyyTBGZr7hnz+qaGTKSRFIvtWzT/PhwcZhlk3zE LWzczhNFXOvmvf48QrWflubKGSsTE6RHC3QNgP2cL8p2exqe8WO9xhf4JmjEU8i6De9n ozuQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f16si2214299eds.152.2020.04.21.13.15.01; Tue, 21 Apr 2020 13:15:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726102AbgDUUOI (ORCPT + 99 others); Tue, 21 Apr 2020 16:14:08 -0400 Received: from paleale.coelho.fi ([176.9.41.70]:57368 "EHLO farmhouse.coelho.fi" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726024AbgDUUOI (ORCPT ); Tue, 21 Apr 2020 16:14:08 -0400 Received: from 91-156-6-193.elisa-laajakaista.fi ([91.156.6.193] helo=redipa) by farmhouse.coelho.fi with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jQzHO-000Mvn-Aj; Tue, 21 Apr 2020 23:14:03 +0300 Message-ID: <404251406c2053b0717af483da50ae04e7be79e3.camel@coelho.fi> From: Luca Coelho To: Sasha Levin , Johannes Berg , kvalo@codeaurora.org Cc: linux-wireless@vger.kernel.org, stable@vger.kernel.org Date: Tue, 21 Apr 2020 23:14:01 +0300 In-Reply-To: <20200421195612.7E5D42074F@mail.kernel.org> References: <20200421195612.7E5D42074F@mail.kernel.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.0-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on farmhouse.coelho.fi X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, TVD_RCVD_IP autolearn=ham autolearn_force=no version=3.4.4 Subject: Re: [PATCH v2 v5.7 4/6] iwlwifi: mvm: limit maximum queue appropriately Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, 2020-04-21 at 19:56 +0000, Sasha Levin wrote: > Hi > > [This is an automated email] > > This commit has been processed because it contains a -stable tag. > The stable tag indicates that it's relevant for the following trees: 4.9+ > > The bot has tested the following trees: v5.6.5, v5.5.18, v5.4.33, v4.19.116, v4.14.176, v4.9.219. > > v5.6.5: Build OK! > v5.5.18: Build OK! > v5.4.33: Build OK! > v4.19.116: Failed to apply! Possible dependencies: > 1169310fa9a8 ("iwlwifi: refactor txq_alloc for supporting more command type") > 2d8c261511ab ("iwlwifi: add d3 debug data support") > 718a8b23ad04 ("iwlwifi: unite macros with same meaning") > 8093bb6d4fee ("iwlwifi: add PCI IDs for the 22260 device series") > 99448a8c1145 ("iwlwifi: mvm: move queue management into sta.c") > 9b3089bd820d ("iwlwifi: pcie: allow using tx init for other queues but the command queue") > a98e2802a654 ("iwlwifi: correct one of the PCI struct names") > afc1e3b4fc8f ("iwlwifi: mvm: use correct GP2 register address for 22000 family") > b998fbbd531f ("iwlwifi: implement BISR HW workaround for 22260 devices") > c30aef01bae9 ("iwlwifi: set 512 TX queue slots for AX210 devices") > c96b5eec2105 ("iwlwifi: refactor NIC init sequence") > cefec29ebdde ("iwlwifi: pcie: align licensing to dual GPL/BSD") > ff911dcaa2e4 ("iwlwifi: introduce device family AX210") > > v4.14.176: Failed to apply! Possible dependencies: > 0e1be40a45d7 ("iwlwifi: mvm: allow reading UMAC error data from SMEM in A000 devices") > 251985c92865 ("iwlwifi: mvm: use shorter queues for mgmt and auxilary queues") > 2ee824026288 ("iwlwifi: pcie: support context information for 22560 devices") > 2f7a3863191a ("iwlwifi: rename the temporary name of A000 to the official 22000") > 33708052993c ("iwlwifi: add support for 22560 devices") > 3485e76e7349 ("iwlwifi: define minimum valid address for umac_error_event_table in cfg") > 5369774c84ea ("iwlwifi: add TX queue size parameter to TX queue allocation") > 718a8b23ad04 ("iwlwifi: unite macros with same meaning") > 8093bb6d4fee ("iwlwifi: add PCI IDs for the 22260 device series") > 80b0ebd488b3 ("Merge tag 'iwlwifi-next-for-kalle-2017-11-29' of git://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-next") > ab27926d9e4a ("iwlwifi: fix devices with PCI Device ID 0x34F0 and 11ac RF modules") > cb8550e15bd1 ("iwlwifi: fix multi queue notification for a000 devices") > dd05f9aab442 ("iwlwifi: pcie: dynamic Tx command queue size") > e59a00f48848 ("iwlwifi: fix indentation in a000 family configuration") > fb5b28469d2a ("iwlwifi: mvm: move umac_error_event_table validity check to where it's set") > ff911dcaa2e4 ("iwlwifi: introduce device family AX210") > > v4.9.219: Failed to apply! Possible dependencies: > 01796ff2fa6e ("iwlwifi: mvm: always free inactive queue when moving ownership") > 0aaece81114e ("iwlwifi: split firmware API from iwl-trans.h") > 1ea423b0e047 ("iwlwifi: remove unnecessary dev_cmd_headroom parameter") > 310181ec34e2 ("iwlwifi: move to TVQM mode") > 5594d80e9bf4 ("iwlwifi: support two phys for a000 devices") > 623e7766be90 ("iwlwifi: pcie: introduce split point to a000 devices") > 65e254821cee ("iwlwifi: mvm: use firmware station PM notification for AP_LINK_PS") > 6b35ff91572f ("iwlwifi: pcie: introduce a000 TX queues management") > 727c02dfb848 ("iwlwifi: pcie: cleanup rfkill checks") > 8236f7db2724 ("iwlwifi: mvm: assign cab queue to the correct station") > 87d0e1af9db3 ("iwlwifi: mvm: separate queue mapping from queue enablement") > bb49701b41de ("iwlwifi: mvm: support a000 SCD queue configuration") > cf90da352a32 ("iwlwifi: mvm: use mvm_disable_queue instead of sharing logic") > d172a5eff629 ("iwlwifi: reorganize firmware API") > df88c08d5c7e ("iwlwifi: mvm: release static queues on bcast release") > eda50cde58de ("iwlwifi: pcie: add context information support") > > > NOTE: The patch will not be queued to stable trees until it is upstream. > > How should we proceed with this patch? Same thing as with the other patches: We definitely don't want all these dependencies. Some functions were moved around and that's what's causing the failures. I'll rebase this patch for those kernels where it failed and submit separately. -- Luca.