Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp277095ybz; Tue, 21 Apr 2020 20:49:53 -0700 (PDT) X-Google-Smtp-Source: APiQypLV2qSMiEpvUFYUWmF7XU8qJRejW9/N6nooPGG4hcrXfu2wnUwaed+hJGDXGeoZObgZ007w X-Received: by 2002:a50:da4a:: with SMTP id a10mr21823684edk.158.1587527392979; Tue, 21 Apr 2020 20:49:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587527392; cv=none; d=google.com; s=arc-20160816; b=RvLq1JFf9kz02jtaR1wu0qsnSs2E5BV6k5ADDVXp6XT8fP/OfhzSzOQrroAdBj0eko qVMVEVqexgS26i3tSQ9YSN2sB4I9YMbI9sb3iY+PiAbAPPgnLjXXA5GkFx359Z6WPkAb zFObk2ui8rAIkPU5mUajX8Yh5apa8PhXjuNHNCGGNBoaunMIZfWZJO1fVDYIFZp6rmuG Ipj1Mvk0WI99SSzCsqNc562tbV0qJ8AYaTE/3od+hrJn1qbwahW9df62HwsY7dEIwNi5 ONl2QaXwS48Jh2NfIdmhwD/w/0g8fyVGlAMgh6rv+22Wxt/2XxNdh5X8b+/1DGYuqbk4 OIuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:authenticated-by; bh=IhD6YmLVdxodtCl0VqMjhRNIak4bR/GBffaoPkebDPc=; b=VbV7eLkcYhcX9jmjIW+STagifuha21285cgYBccCtXqetW5Zdb8JgnHKFPWMgxAZen 24ZWuLA4ZfjUD3+Jjen2H59EL6qEHdETjMILrSgiX1NMSZ8jU6IfDFvSkAnURxCEjZMW /9/Z1Kc9IBToZUpB1i0pO2JDhMSN47mPGLOZa/lrsXuHxArWVb0/6hvld2J1oZ7m+/RS aPvu+YQhaiLVpGW8AEhNw4x5ZesfwERgdP2V8jjbUo/S/yVGeD4zeYekS2/iL5iHvuts urY5c2QWwRVZAiXcdebYYdEjwLKnYgeVeyZzn/otewwkbYgf3cYYQTGNzLyPo6hg+EIo g2XQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n12si2910360eds.584.2020.04.21.20.49.29; Tue, 21 Apr 2020 20:49:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726430AbgDVDqX (ORCPT + 99 others); Tue, 21 Apr 2020 23:46:23 -0400 Received: from rtits2.realtek.com ([211.75.126.72]:36998 "EHLO rtits2.realtek.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726457AbgDVDqS (ORCPT ); Tue, 21 Apr 2020 23:46:18 -0400 Authenticated-By: X-SpamFilter-By: ArmorX SpamTrap 5.69 with qID 03M3kAzD5004569, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexmb06.realtek.com.tw[172.21.6.99]) by rtits2.realtek.com.tw (8.15.2/2.66/5.86) with ESMTPS id 03M3kAzD5004569 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Wed, 22 Apr 2020 11:46:10 +0800 Received: from RTEXMB04.realtek.com.tw (172.21.6.97) by RTEXMB06.realtek.com.tw (172.21.6.99) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1779.2; Wed, 22 Apr 2020 11:46:10 +0800 Received: from localhost.localdomain (172.21.68.128) by RTEXMB04.realtek.com.tw (172.21.6.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1779.2; Wed, 22 Apr 2020 11:46:10 +0800 From: To: CC: , Subject: [PATCH v2 2/8] rtw88: no need to send additional information to legacy firmware Date: Wed, 22 Apr 2020 11:46:01 +0800 Message-ID: <20200422034607.28747-3-yhchuang@realtek.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200422034607.28747-1-yhchuang@realtek.com> References: <20200422034607.28747-1-yhchuang@realtek.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [172.21.68.128] X-ClientProxiedBy: RTEXMB02.realtek.com.tw (172.21.6.95) To RTEXMB04.realtek.com.tw (172.21.6.97) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Ping-Ke Shih The firmware of 11AC devices need more information to support more offload functions, such as IQK. And 11N devices such as 8723D does not support offload these function in firmware, there is no need to send these additional information to firmware when it comes to 11N devices. Signed-off-by: Ping-Ke Shih Signed-off-by: Yan-Hsuan Chuang --- drivers/net/wireless/realtek/rtw88/fw.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/wireless/realtek/rtw88/fw.c b/drivers/net/wireless/realtek/rtw88/fw.c index 209853fdcb42..dde7823143ea 100644 --- a/drivers/net/wireless/realtek/rtw88/fw.c +++ b/drivers/net/wireless/realtek/rtw88/fw.c @@ -271,6 +271,9 @@ rtw_fw_send_general_info(struct rtw_dev *rtwdev) u8 h2c_pkt[H2C_PKT_SIZE] = {0}; u16 total_size = H2C_PKT_HDR_SIZE + 4; + if (rtw_chip_wcpu_11n(rtwdev)) + return; + rtw_h2c_pkt_set_header(h2c_pkt, H2C_PKT_GENERAL_INFO); SET_PKT_H2C_TOTAL_LEN(h2c_pkt, total_size); @@ -291,6 +294,9 @@ rtw_fw_send_phydm_info(struct rtw_dev *rtwdev) u16 total_size = H2C_PKT_HDR_SIZE + 8; u8 fw_rf_type = 0; + if (rtw_chip_wcpu_11n(rtwdev)) + return; + if (hal->rf_type == RF_1T1R) fw_rf_type = FW_RF_1T1R; else if (hal->rf_type == RF_2T2R) -- 2.17.1