Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1445500ybz; Wed, 22 Apr 2020 21:55:26 -0700 (PDT) X-Google-Smtp-Source: APiQypKHeC+1QYdf4n2uOKWR/WZzQ3Z4/6L2OLnCcSSX5YfaU81QLwnC8vHhxRJpqWDrQi8KOcpj X-Received: by 2002:a17:906:18a2:: with SMTP id c2mr1258452ejf.167.1587617726461; Wed, 22 Apr 2020 21:55:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587617726; cv=none; d=google.com; s=arc-20160816; b=rgfQdGIL1FoyZTeSorcAl3eEYqT9+Yu9iZpqN2QwgHuqQlfv++7MfYmxCuG44MA0Nr khAlnBYtwtiTgN+4jMR6OPFVl2Bt3c8uD2iWjdPqDWgbCn/TE40FpgqiaWLMmqFsi7tJ qs5eHLbhATishvilVNFmfapSKEOOmdMDRpNSV4jLPyBVNdPyH83uR18hrDjGWfamexBD PwpgxrLO+BIWJUSoqqXLQwCh+xzn9S8+MYIy3HZYNn1n6/bLqeVruNsPKMXqFpO/cKdL mLsTr0+9Q34ykzco0uwLCbGA6RW6uqVWBpx8v6FQvzRC1H16NmexsaoL/1jDiQqD74ue a03Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature; bh=3gaGITc2mtUH4RMdNO+XHqahY0BeFHkvQfICw+F+45I=; b=kZHeqFB+oIBlarF+G7fznXAfFz7RnbHwCJ7TIQ+TDHfpjotu/h0hvRasQuC9+Z2mS4 S9a91v65OUSYlIWG2yzCSv5LqPPxT88oBOjtXktImhLHLR5n9vpBxFwPio2YqZX6RnIB oK7tz7wwUpBeK4izqVW5Lg1z+yfnxdePaSO2w0/RZf3YNFeo0F4k2nAUBYNt1+oPHCS0 2R736URxrSpXeLjpz98IJ3HowYKLnv8hnzDjSNA/EwZomRs3vD4D2tl1LZhTFsGBpq0k 9yCkcU0QHMHOCngygHnMdaVHghYEdGaU1MIF5s1MAM79Mi64kEgZUiQ8uGrs0DfxE4GK sm7A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=OhU1PEt3; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w7si588708edr.309.2020.04.22.21.55.03; Wed, 22 Apr 2020 21:55:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=OhU1PEt3; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726027AbgDWExS (ORCPT + 99 others); Thu, 23 Apr 2020 00:53:18 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:31645 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725906AbgDWExS (ORCPT ); Thu, 23 Apr 2020 00:53:18 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1587617597; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=3gaGITc2mtUH4RMdNO+XHqahY0BeFHkvQfICw+F+45I=; b=OhU1PEt3PkeFK49S4sd4iCamEtB4P2O3+X48jsGzpkjv4bGmcQ13zoOX/k8iRzgKEXpsPDYV l1+Wd437m3vmaUeP+P7BIsZpoKa//H0BwdF9TeR9r7DirdtJ1O8ACfGP6gLb9koWL1eIps2B KLK6KzDPpW/Sj0Ab3M/721asNN8= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5ea11f2b.7f6670cb7df8-smtp-out-n05; Thu, 23 Apr 2020 04:52:59 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 053FEC433D2; Thu, 23 Apr 2020 04:52:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.5 required=2.0 tests=ALL_TRUSTED,MISSING_DATE, MISSING_MID,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id AB336C433CB; Thu, 23 Apr 2020 04:52:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org AB336C433CB Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] ath10k: Fix the invalid tx/rx chainmask configuration From: Kalle Valo In-Reply-To: <1587495512-29813-1-git-send-email-mkenna@codeaurora.org> References: <1587495512-29813-1-git-send-email-mkenna@codeaurora.org> To: Maharaja Kennadyrajan Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, Maharaja Kennadyrajan User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20200423045259.053FEC433D2@smtp.codeaurora.org> Date: Thu, 23 Apr 2020 04:52:59 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Maharaja Kennadyrajan wrote: > The driver is allowing the invalid tx/rx chainmask configuration > (other than 1,3,7,15) set by the user. It causes the firmware > crash due to the invalid chainmask values. > > Hence, reject the invalid chainmask values in the driver by not > sending the pdev set command to the firmware. > > Tested hardware: QCA9888 > Tested firmware: 10.4-3.10-00047 > > Signed-off-by: Maharaja Kennadyrajan > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. aac392d8553f ath10k: Fix the invalid tx/rx chainmask configuration -- https://patchwork.kernel.org/patch/11502099/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches