Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1963516ybz; Thu, 23 Apr 2020 09:08:34 -0700 (PDT) X-Google-Smtp-Source: APiQypInJJV2icPzQqnDLGJ5Zmgf+lYgch2fLzNYp0kEDysks9jGlRgpBkogqumVBXMbcRvzoNvf X-Received: by 2002:a05:6402:30ad:: with SMTP id df13mr3323050edb.339.1587658114285; Thu, 23 Apr 2020 09:08:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587658114; cv=none; d=google.com; s=arc-20160816; b=Ymkk+vUeDCqSljmBjq77Wp5UEf3OS2T7r41QQrXae2fF7S7mEaY/3qvDb9+3LV9mg2 dB6BW45nRObtBQmYhKE+wMQ3OMXBSDowHM4TYpXx3o6aWgh7ZRlSCmF5K1heyqdOIhK6 Uq2xmCJCAkbFTwopkIAfKTqDfOKurfvDHI7n7K51W/zkyqdHbvtiol+NdUKzseN5fRuz UxOF/Mc/jD3/JIx0BZ7TROuYkxYqCr1hOh0U3qhb2kxTOtCmqnDoAOM2WtP35BtU2Fvh l9R0mgPiF8/LODl89t8/7h69BCIMtPr5eE41HSMni+iDHqJpAyOoePhq4mvn3BRHI84t rdvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature; bh=qbSJxZQNaWxw8mAgGamaaFomuWjyilvDfwW/TLq0WJQ=; b=guWXK75rU2WCzkcFZ2xDhMNmXVLy/e4h6l9GwcHeCz4eIcT2gTAQ/60N9NGZRogvKy 6V9av/nNwcJYmLzisdL+7VveYnbYN4u3GSqFKdX15ChDY1M93JsI6deESYPp2LeJDsPL kIv4hNjyX64pR2GaU5qirE6vSd+pR0JTnTA2fM0t941Qx0i1vuTu5XJ8uuhmY1k+Yk4r +YqoN5alovdLdE6cao5/hiKTXnAawju9QJqkWYNcRu3zN4DL6bzKcleDyTbS6wotqXGK JkM8dfUzymzZtP2CfBSerf+FDN7aVJmg88rjnPCm/6EVNWt52oqg0XOQdYvBj5vFs4cf weLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=HeUsEs52; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k26si1553177ejc.127.2020.04.23.09.07.53; Thu, 23 Apr 2020 09:08:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=HeUsEs52; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729540AbgDWQHM (ORCPT + 99 others); Thu, 23 Apr 2020 12:07:12 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:50887 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729507AbgDWQHM (ORCPT ); Thu, 23 Apr 2020 12:07:12 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1587658031; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=qbSJxZQNaWxw8mAgGamaaFomuWjyilvDfwW/TLq0WJQ=; b=HeUsEs529UxBWdZmYKXQPjoZIgszf4J+nYu1moXwSg0LqDPLHscdbQxuZvj1XIc2aM0WHKNG mSRQdFqUrBPZTKS6XnHh2lf9jOmf1fDb3zeIZwemXOCHtNeSeBK+OH4mkpcAOFG3hhTU48u8 z+KgrBrtNwDx3NGqQ0d7XwJ7bq8= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5ea1bd2a.7f736ae07c38-smtp-out-n01; Thu, 23 Apr 2020 16:07:06 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id E24FDC433D2; Thu, 23 Apr 2020 16:07:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.5 required=2.0 tests=ALL_TRUSTED,MISSING_DATE, MISSING_MID,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id BCF2BC433D2; Thu, 23 Apr 2020 16:07:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org BCF2BC433D2 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2 2/2] rtw88: Use udelay instead of usleep in atomic context From: Kalle Valo In-Reply-To: <20200423073007.3566-1-kai.heng.feng@canonical.com> References: <20200423073007.3566-1-kai.heng.feng@canonical.com> To: Kai-Heng Feng Cc: yhchuang@realtek.com, Kai-Heng Feng , "David S. Miller" , linux-wireless@vger.kernel.org (open list:REALTEK WIRELESS DRIVER (rtw88)), netdev@vger.kernel.org (open list:NETWORKING DRIVERS), linux-kernel@vger.kernel.org (open list) User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20200423160704.E24FDC433D2@smtp.codeaurora.org> Date: Thu, 23 Apr 2020 16:07:04 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Kai-Heng Feng wrote: > It's incorrect to use usleep in atomic context. > > Switch to a macro which uses udelay instead of usleep to prevent the issue. > > Fixes: 6343a6d4b213 ("rtw88: Add delay on polling h2c command status bit") > Signed-off-by: Kai-Heng Feng For patch 1 please also CC linux-wireless, otherwise patchwork cannot see it. -- https://patchwork.kernel.org/patch/11505147/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches