Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 2C03BC433CB
From:   Kalle Valo <kvalo@codeaurora.org>
To:     kbuild test robot <lkp@intel.com>
Cc:     Ping-Ke Shih <pkshih@realtek.com>, kbuild-all@lists.01.org,
        Yan-Hsuan Chuang <yhchuang@realtek.com>,
        linux-wireless@vger.kernel.org
Subject: Re: [wireless-drivers-next:master 41/48] drivers/net/wireless/realtek/rtw88/mac.c:653:5: sparse: sparse: symbol '__rtw_download_firmware' was not declared. Should it be static?
References: <202004241610.NSbGjIMy%lkp@intel.com>
Date:   Fri, 24 Apr 2020 12:45:49 +0300
In-Reply-To: <202004241610.NSbGjIMy%lkp@intel.com> (kbuild test robot's
        message of "Fri, 24 Apr 2020 16:57:52 +0800")
Message-ID: <87r1wdgqsy.fsf@kamboji.qca.qualcomm.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

+ linux-wireless

kbuild test robot <lkp@intel.com> writes:

> tree:
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git
> master
> head:   75e69fb11b40ba1256b14f943c7050682c1f5458
> commit: 15d2fcc6b2dea46986e55cd3808c0dbb480a6c8d [41/48] rtw88: add
> legacy firmware download for 8723D devices
> reproduce:
>         # apt-get install sparse
>         # sparse version: v0.6.1-191-gc51a0382-dirty
>         git checkout 15d2fcc6b2dea46986e55cd3808c0dbb480a6c8d
>         make ARCH=x86_64 allmodconfig
>         make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kbuild test robot <lkp@intel.com>
>
>
> sparse warnings: (new ones prefixed by >>)
>
>>> drivers/net/wireless/realtek/rtw88/mac.c:653:5: sparse: sparse:
>>> symbol '__rtw_download_firmware' was not declared. Should it be
>>> static?
>>> drivers/net/wireless/realtek/rtw88/mac.c:817:5: sparse: sparse:
>>> symbol '__rtw_download_firmware_legacy' was not declared. Should it
>>> be static?
>
> Please review and possibly fold the followup patch.

Tony, please send the patch via linux-wireless so that patchwork sees
it.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches