Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp757033ybz; Fri, 24 Apr 2020 08:47:17 -0700 (PDT) X-Google-Smtp-Source: APiQypIFMjUL+OeVbQAlWuzg9DbMdZsF46fXfrRjgc8ro2Q+CE7v60gboE/s91VFI4qmvwE+p1VC X-Received: by 2002:a50:c28a:: with SMTP id o10mr7933885edf.85.1587743237610; Fri, 24 Apr 2020 08:47:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587743237; cv=none; d=google.com; s=arc-20160816; b=FzmL1oqaSyZx+dxfdIrtqKzzr6Gdye6deeiSoI8q9S+Jvs9pDhAevvjtg0GYANIkWS YWO/Yp3J/mBqeh0c14mxry2ZuTCgFBs/pv7AEnNw2cR28cLk3f4AtcWZjcFsnfb/rOHe rO13oyBMxX8Zs8krXlCIzU8rKYwkIsVKLCBq1fvpSHsLvwcNHihmj8ahAZ5cpuUnGO+/ zcOkcUk4wf/2VcWWKye94PZOz79Zeg3qaqSkTwJ4urEQdqo9ZJjkGAfJbJ0mVrRjcNYc XQMKx5uVj9z7xpWK9rCQq/DjHNTHIUJrbE4QiVUJlSU70iWndDcS5LMLqIoVMnO+V6KK OlIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=pHljsnXz5miNFABh7tHnaU3mM2ahac4U4h6sQkGU5wE=; b=NLfjlaKzioWqQkLRXOzJku0eJ9NdoiVYKAylPHQOevLEJTThXsTOvwCS12LYIBYqJq 5uHWxEof9EMrm4ILrPsqjiJx1sU0lyoqTg/kAVKVPD6bDyCQay6EDISLTboprDBZy1jY Xc+uI+OF7eS7OBReNkEXD/gp0KJIUDDNSPXsYPfmQ2RKj/yfIdw3LXfcuhXFtfCC0Icn 5i0fpGHPdjOgrS7AkE8ILzs6QvO+EjJzhSEqOoxOEZcEHwfvy1AZzy9/9DB20ZtCkciF U8PGnEjEZRIg8A99EKdfrO7TnIE6YYBloEwQCjLtHw6G8IQp7ihO1BCKLoIQgklDjCWD w0iQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v28si3764251edb.497.2020.04.24.08.46.30; Fri, 24 Apr 2020 08:47:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728437AbgDXPpp (ORCPT + 99 others); Fri, 24 Apr 2020 11:45:45 -0400 Received: from smtp04.smtpout.orange.fr ([80.12.242.126]:48688 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727819AbgDXPpp (ORCPT ); Fri, 24 Apr 2020 11:45:45 -0400 Received: from localhost.localdomain ([92.148.159.11]) by mwinf5d39 with ME id WflZ2200F0F2omL03fldWL; Fri, 24 Apr 2020 17:45:42 +0200 X-ME-Helo: localhost.localdomain X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Fri, 24 Apr 2020 17:45:42 +0200 X-ME-IP: 92.148.159.11 From: Christophe JAILLET To: stas.yakovlev@gmail.com, kvalo@codeaurora.org, davem@davemloft.net Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET Subject: [PATCH v2] ipw2x00: Remove a memory allocation failure log message Date: Fri, 24 Apr 2020 17:45:27 +0200 Message-Id: <20200424154527.27309-1-christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Axe a memory allocation failure log message. This message is useless and incorrect (vmalloc is not used here for the memory allocation) This has been like that since the very beginning of this driver in commit 43f66a6ce8da ("Add ipw2200 wireless driver.") Signed-off-by: Christophe JAILLET --- v2: remove a useless empty line --- drivers/net/wireless/intel/ipw2x00/ipw2200.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/intel/ipw2x00/ipw2200.c b/drivers/net/wireless/intel/ipw2x00/ipw2200.c index 60b5e08dd6df..30c4f041f565 100644 --- a/drivers/net/wireless/intel/ipw2x00/ipw2200.c +++ b/drivers/net/wireless/intel/ipw2x00/ipw2200.c @@ -3770,10 +3770,8 @@ static int ipw_queue_tx_init(struct ipw_priv *priv, struct pci_dev *dev = priv->pci_dev; q->txb = kmalloc_array(count, sizeof(q->txb[0]), GFP_KERNEL); - if (!q->txb) { - IPW_ERROR("vmalloc for auxiliary BD structures failed\n"); + if (!q->txb) return -ENOMEM; - } q->bd = pci_alloc_consistent(dev, sizeof(q->bd[0]) * count, &q->q.dma_addr); -- 2.20.1