Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp731401ybz; Sat, 25 Apr 2020 03:06:14 -0700 (PDT) X-Google-Smtp-Source: APiQypISaWXnVoc5205mQ24Sdi0NYRZWL+hz+3tRO+4ixwtCWQhIAJXF0ZMG05g2rKv+YQnaq0lb X-Received: by 2002:aa7:c40e:: with SMTP id j14mr11449622edq.125.1587809174335; Sat, 25 Apr 2020 03:06:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587809174; cv=none; d=google.com; s=arc-20160816; b=U0FVR7h0EMrdNhH/Ln7s/2YWVoDtK/ycwPBrK5L0sWb6WfX0qCV5cS4D6YrLrIJosv evMdeMgOzf7RYjwWbprIjmhbH0urBk34rEg8qa+owfz88Wdd/1Svf4JKB0n51aX8I8IQ Xnl+kj2A/lLoGgrU7LTmKB1kD94mVVWJWEXPvm0Z8O025J8ASLr9PcYqrJr/YMSMgY8h VgYkFf9uaYepxQ8EWfEsfmDN+S3KxBbA9QbV2+kf5Se+dCjKpVsFB5sB06hWDj0d5Xv1 eT6qjCetaBLltYEQLcXbLScQRaaENhf830BOStueN4pvlCCvRonLYZSqv0++mHyrhIHm fsmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:cc:to:from; bh=nO7fqCcQx/m+exWiF/FsP8gDP6UmGif0BqsUbuypK9E=; b=dvbUdhGRIMwNGfPFfhOl9AQIGeoOMKy0ctDta3LcNvgfw5hrQg63w4MVli700PXz4v rNyQdedTaPr2wrMGInrZfK7CcKA7m8FYj9H49bnMxB0z/odsmWAhrjh6V5V2yDMpT3pj KzJtmq4Lx8V7Hxuix+98UzoSgEgzaE1ddr/9dc9B8xkmOSTskOTHMKOUbicK/bA2RwK7 YsO8CXZVEmnVeOvSMy1eLsOjCEGkx4fyALwMgJUN65NzOe/aFtAn9xAYH9warG6PiZ7I mwbwu11SNZdc0a1c2K7LRv/oN1jPPS11uOZSjsaVcs55j27THut+VjR9IzQ0xVyNuVzG 9LUg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id va12si4532052ejb.227.2020.04.25.03.05.41; Sat, 25 Apr 2020 03:06:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726348AbgDYKFS (ORCPT + 99 others); Sat, 25 Apr 2020 06:05:18 -0400 Received: from paleale.coelho.fi ([176.9.41.70]:58242 "EHLO farmhouse.coelho.fi" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726116AbgDYKFQ (ORCPT ); Sat, 25 Apr 2020 06:05:16 -0400 Received: from 91-156-6-193.elisa-laajakaista.fi ([91.156.6.193] helo=redipa.ger.corp.intel.com) by farmhouse.coelho.fi with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jSHgP-000P3t-Gh; Sat, 25 Apr 2020 13:05:13 +0300 From: Luca Coelho To: kvalo@codeaurora.org Cc: linux-wireless@vger.kernel.org Date: Sat, 25 Apr 2020 13:04:54 +0300 Message-Id: X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200425100459.2778317-1-luca@coelho.fi> References: <20200425100459.2778317-1-luca@coelho.fi> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on farmhouse.coelho.fi X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, TVD_RCVD_IP autolearn=ham autolearn_force=no version=3.4.4 Subject: [PATCH 06/11] iwlwifi: use longer queues for 256-BA Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Johannes Berg When we have 256 block-ack support, we may need to be very fast to provide a lot of frames to the hardware to transmit, but that cannot be guaranteed. Use a longer queue size to have more time, and the next possible queue size is 1024 since it must be a power of two. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/cfg/22000.c | 2 +- drivers/net/wireless/intel/iwlwifi/iwl-fh.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/cfg/22000.c b/drivers/net/wireless/intel/iwlwifi/cfg/22000.c index 1fcc346ba425..1daa653bcb99 100644 --- a/drivers/net/wireless/intel/iwlwifi/cfg/22000.c +++ b/drivers/net/wireless/intel/iwlwifi/cfg/22000.c @@ -211,7 +211,7 @@ static const struct iwl_ht_params iwl_22000_ht_params = { .trans.base_params = &iwl_ax210_base_params, \ .min_txq_size = 128, \ .gp2_reg_addr = 0xd02c68, \ - .min_256_ba_txq_size = 512, \ + .min_256_ba_txq_size = 1024, \ .mon_dram_regs = { \ .write_ptr = { \ .addr = DBGC_CUR_DBGBUF_STATUS, \ diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-fh.h b/drivers/net/wireless/intel/iwlwifi/iwl-fh.h index a8e988281eaf..e77d8d13cb51 100644 --- a/drivers/net/wireless/intel/iwlwifi/iwl-fh.h +++ b/drivers/net/wireless/intel/iwlwifi/iwl-fh.h @@ -646,7 +646,7 @@ struct iwl_rb_status { #define TFD_QUEUE_CB_SIZE(x) (ilog2(x) - 3) #define TFD_QUEUE_SIZE_BC_DUP (64) #define TFD_QUEUE_BC_SIZE (TFD_QUEUE_SIZE_MAX + TFD_QUEUE_SIZE_BC_DUP) -#define TFD_QUEUE_BC_SIZE_GEN3 512 +#define TFD_QUEUE_BC_SIZE_GEN3 1024 #define IWL_TX_DMA_MASK DMA_BIT_MASK(36) #define IWL_NUM_OF_TBS 20 #define IWL_TFH_NUM_TBS 25 -- 2.26.2