Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp732354ybz; Sat, 25 Apr 2020 03:07:18 -0700 (PDT) X-Google-Smtp-Source: APiQypJADaslXRMsTU4Y+JW6/5cR0UmRwSoGNatXiAZ5rD/lfVnnxf1hm0+BOnq5U1XvvzkTre8y X-Received: by 2002:aa7:d0c2:: with SMTP id u2mr11626972edo.78.1587809237937; Sat, 25 Apr 2020 03:07:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587809237; cv=none; d=google.com; s=arc-20160816; b=givHUR3FtzCL0mxllCl79kpHS2BgBeBD4Ww0QYS92dWHITz0FF0rMriewbo6LnvIPg bPTnUi3xUZQFM+e/FyTBDXvPm0vPFhDmG0D7iPKJZtSJ0BPKcHNbhyFosltMcuEOmDAb 7/PPJv2v1WdPiaZQeZWOiiSLpG6ib5JjCdPi/RgvyVClthwo2nuq6nFvhU1EYVqLb1Fv NUeA3TDK7ZvxH9Fjf4IcEJZ91XbUwBDprDAWWncQvDalpsdSE+rGhjiDqahrQuIVqH1Q k6s1WYJhEyma5W+1wlEDM6UKtmcpjE69VEeIDv3fkGrPpdig1x6JeSj3qtlDX1/cxFXK 0uLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:cc:to:from; bh=gEUsKicOAiyF14C1KnwqrxevyZ6c4ahvXCH9VOa3Jbw=; b=KOR6b4myCxyS3tbxe/53AWK4oxp8ZuKGQ5NkEqAcNUjFlp695c7uW9mJv6cTK9k2dV r5drSCm5GWiRTeOU4JxG2yhyCW/DoCVn3xkf8l6zDi9RlXqXWEy0XvoYF7886ztBh0mS 3U86m3442mNtIvN0/lNjeSd5lu3ecaRse5kM7iZ59eEE1BFfvYMukGaNSFfZYTAnzrUa TdPPAyg7zhBqQryOCLtXBkXtXDZTAInpRyZapHuSyeQWyaV1UN975SZwb1HuZCbA8lIR n3QhR7NreYMtbDLz5TYwATzSemtsmSeaWbsb8OkigGOehShoMk0+roLPW6e4QfiNmMNq bbFw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b26si4940870edr.228.2020.04.25.03.06.54; Sat, 25 Apr 2020 03:07:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726338AbgDYKFR (ORCPT + 99 others); Sat, 25 Apr 2020 06:05:17 -0400 Received: from paleale.coelho.fi ([176.9.41.70]:58248 "EHLO farmhouse.coelho.fi" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726304AbgDYKFQ (ORCPT ); Sat, 25 Apr 2020 06:05:16 -0400 Received: from 91-156-6-193.elisa-laajakaista.fi ([91.156.6.193] helo=redipa.ger.corp.intel.com) by farmhouse.coelho.fi with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jSHgQ-000P3t-9E; Sat, 25 Apr 2020 13:05:14 +0300 From: Luca Coelho To: kvalo@codeaurora.org Cc: linux-wireless@vger.kernel.org Date: Sat, 25 Apr 2020 13:04:55 +0300 Message-Id: X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200425100459.2778317-1-luca@coelho.fi> References: <20200425100459.2778317-1-luca@coelho.fi> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on farmhouse.coelho.fi X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, TVD_RCVD_IP autolearn=ham autolearn_force=no version=3.4.4 Subject: [PATCH 07/11] iwlwifi: tx: enable A-MSDU in low latency mode Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Mordechay Goodstein Tests have shown that we can meet low latency KPIs with A-MSDU enabled so enable it to achieve max TPT. Signed-off-by: Mordechay Goodstein Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/tx.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/tx.c b/drivers/net/wireless/intel/iwlwifi/mvm/tx.c index a8d0d17f79fd..2f6484e0d726 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/tx.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/tx.c @@ -8,7 +8,7 @@ * Copyright(c) 2012 - 2014 Intel Corporation. All rights reserved. * Copyright(c) 2013 - 2015 Intel Mobile Communications GmbH * Copyright(c) 2016 - 2017 Intel Deutschland GmbH - * Copyright(c) 2018 - 2019 Intel Corporation + * Copyright(c) 2018 - 2020 Intel Corporation * * This program is free software; you can redistribute it and/or modify * it under the terms of version 2 of the GNU General Public License as @@ -31,7 +31,7 @@ * Copyright(c) 2012 - 2014 Intel Corporation. All rights reserved. * Copyright(c) 2013 - 2015 Intel Mobile Communications GmbH * Copyright(c) 2016 - 2017 Intel Deutschland GmbH - * Copyright(c) 2018 - 2019 Intel Corporation + * Copyright(c) 2018 - 2020 Intel Corporation * All rights reserved. * * Redistribution and use in source and binary forms, with or without @@ -920,11 +920,8 @@ static int iwl_mvm_tx_tso(struct iwl_mvm *mvm, struct sk_buff *skb, * No need to lock amsdu_in_ampdu_allowed since it can't be modified * during an BA session. */ - if (info->flags & IEEE80211_TX_CTL_AMPDU && - !mvmsta->tid_data[tid].amsdu_in_ampdu_allowed) - return iwl_mvm_tx_tso_segment(skb, 1, netdev_flags, mpdus_skb); - - if (iwl_mvm_vif_low_latency(iwl_mvm_vif_from_mac80211(mvmsta->vif)) || + if ((info->flags & IEEE80211_TX_CTL_AMPDU && + !mvmsta->tid_data[tid].amsdu_in_ampdu_allowed) || !(mvmsta->amsdu_enabled & BIT(tid))) return iwl_mvm_tx_tso_segment(skb, 1, netdev_flags, mpdus_skb); -- 2.26.2