Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp2742035ybz; Mon, 27 Apr 2020 03:45:29 -0700 (PDT) X-Google-Smtp-Source: APiQypKNW1HuuUd4e7CkjWusmiOMpTNdjiNvqKgRRyrWrOqjM95QKRgVN26cfLKMgiiiRQHoFecu X-Received: by 2002:a17:906:27d1:: with SMTP id k17mr18486241ejc.134.1587984329283; Mon, 27 Apr 2020 03:45:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587984329; cv=none; d=google.com; s=arc-20160816; b=RmT9RahxaJLdDbTO4NB/n+4XRrMQnwOMcWzsxdCtOK+Gikfwcg7dcnqTn5aR41i8c+ Vb9mMxQLc3E1TZAYzWt3sqUJTz8WCU3G4m+tgu3lyqv5Pvn4veu0bQT/ccCfkujumiWp 6wbRShVN/XEguOwZdsKAywGH/jfOsP5JiuRSZ/ZKXiJ+x4MPYzjMFtziFXhMfPIj3Y7B RbUgmZRUTnLThYqAA4+u4+BT7p3eqFJZKTenrIdK34OSr46et/jRtLS+7Vs+SiPsnIA2 68k0cnHQXnlThCsoASlwNdsyu0buGG6XvFobwXVuVdn3Mi6N6MJx1+sKFOC9CMLg9exe AyOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=dqXEuVJROPRyCMb8IE1/iZs6cj/A+XsJwyYOZkkZHqs=; b=bASP6cEoC+y2XMhWErJ75+tp54YDDak0Rcl9DPdXGsfg5uGpYO71ZAbv5Af6yGbx0a 3TT7VdM8sWlMjokl7xJwYxBA09WcTGFlkY7QYmfbKHmTrvzwRVdfCz4Dic18JmPpdLLh EpvYE4zF7rH1AvK88GUZNpKj6y9MLwwG+bsNDkq+taWVUxW9YucCt3lb/YtibDe0wfyl zrr4Bmi2NwETGRURB/xjc1jlsjAByk6Au92cAn29vIsa2uZwsXOT6XvAHU7QoYOPEuaJ T4b+kjxnUfONuT9sEZ7dUhLoR7UVZFvczvhwAYoPQeiT165NTqHv7A/LPr3f/lhLHpsn wsbQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dn12si10731717ejc.52.2020.04.27.03.44.54; Mon, 27 Apr 2020 03:45:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727056AbgD0Kmw (ORCPT + 99 others); Mon, 27 Apr 2020 06:42:52 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:43736 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727040AbgD0Kmv (ORCPT ); Mon, 27 Apr 2020 06:42:51 -0400 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 2FBBC812F8071EDB3218; Mon, 27 Apr 2020 18:42:50 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.487.0; Mon, 27 Apr 2020 18:42:43 +0800 From: Wei Yongjun To: Kalle Valo CC: Wei Yongjun , , , Subject: [PATCH net-next] ath11k: remove redundant dev_err call in ath11k_ahb_probe() Date: Mon, 27 Apr 2020 10:44:03 +0000 Message-ID: <20200427104403.14598-1-weiyongjun1@huawei.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun --- drivers/net/wireless/ath/ath11k/ahb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath11k/ahb.c b/drivers/net/wireless/ath/ath11k/ahb.c index e7e3e64c07aa..7d3d1cc6f39f 100644 --- a/drivers/net/wireless/ath/ath11k/ahb.c +++ b/drivers/net/wireless/ath/ath11k/ahb.c @@ -897,10 +897,8 @@ static int ath11k_ahb_probe(struct platform_device *pdev) } mem = devm_ioremap_resource(&pdev->dev, mem_res); - if (IS_ERR(mem)) { - dev_err(&pdev->dev, "ioremap error\n"); + if (IS_ERR(mem)) return PTR_ERR(mem); - } ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); if (ret) {