Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp2743927ybz; Mon, 27 Apr 2020 03:47:58 -0700 (PDT) X-Google-Smtp-Source: APiQypKn3FizLFGWJBhs+oOoHa2q91CJlPXRPvCMnfTTWG4SIF2A7OzoE47h9LMzLG7/r75kWkdd X-Received: by 2002:a50:b285:: with SMTP id p5mr1156374edd.150.1587984478055; Mon, 27 Apr 2020 03:47:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587984478; cv=none; d=google.com; s=arc-20160816; b=skp0AtD8k/srCpVHMKQsF9TDpK+YAUdXbhtdbw0ngDsAWa1Uxr2EvyRt1ZMmd8mB+6 c0uSik9lR56FGcONY8DCb2iq+PtAChUsVRu/8XYt50OR4LMK1uyYLmTyMSDGV6kN6q5j +6KaeF+K6JFz8S6azeFwGsuWTb/cSAJg8bnhZco8IyFBDfw6C7aMwmIomkT0FSLu4y2V 3/gAcROb8EczQB8r+DO/QU3T+oMoOZ1SKRgkBl9TCJudGhzCk7ZC3G3Unv0BqfTnQFv9 l2vedNtAIXsgI0GDL79i/sha/0lgC6F6eGoh/uwKtvDYw+T4J7rlKMt+ZV894QIlzje5 DXgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=HSLJeNg9vO6lO/GQnwxHfQwzH+OO6Jliija56Z6AZrA=; b=V+ertdS+yXVRU5IC93bn6y2bxBe6o9baKgTTrjmXNmRBNMqumwarlwWsMdAIu0bKbw 4+od6/xamhh9O9piMgv+SP1A/lbWFLu1pqGUN46qocZ4zcyd+LQIWRLvUpSd3+qu48Bz +684TnpOScU4+gNjVAAO+gKPu/BGo7bgRByFWpuM/xfS4cHL1rNAaFvSQSKyYn/Lcas+ rEJQ5LQEg5y1PG3eiCWo05rpDD76+MWI6y7xvWcK8hzRAF3T8vAMZhUUMeI7ytmMPtll nZBk1tQIDtrp7rp4cg1lf0HLZPas/aDKMXQ5nFRCKNKkSvqQSALtY5Avnt2zjwyIdB5O 1MoQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t5si7430299edj.346.2020.04.27.03.47.34; Mon, 27 Apr 2020 03:47:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726855AbgD0KpQ (ORCPT + 99 others); Mon, 27 Apr 2020 06:45:16 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:3350 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726721AbgD0KpP (ORCPT ); Mon, 27 Apr 2020 06:45:15 -0400 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 857609184C37FC15E13C; Mon, 27 Apr 2020 18:45:12 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.487.0; Mon, 27 Apr 2020 18:45:01 +0800 From: Wei Yongjun To: Kalle Valo , John Crispin CC: Wei Yongjun , , , Subject: [PATCH net-next] ath11k: fix error return code in ath11k_dp_alloc() Date: Mon, 27 Apr 2020 10:46:21 +0000 Message-ID: <20200427104621.23752-1-weiyongjun1@huawei.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fix to return negative error code -ENOMEM from the error handling case instead of 0, as done elsewhere in this function. Fixes: d0998eb84ed3 ("ath11k: optimise ath11k_dp_tx_completion_handler") Signed-off-by: Wei Yongjun --- drivers/net/wireless/ath/ath11k/dp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath11k/dp.c b/drivers/net/wireless/ath/ath11k/dp.c index 50350f77b309..2f35d325f7a5 100644 --- a/drivers/net/wireless/ath/ath11k/dp.c +++ b/drivers/net/wireless/ath/ath11k/dp.c @@ -909,8 +909,10 @@ int ath11k_dp_alloc(struct ath11k_base *ab) dp->tx_ring[i].tx_status_head = 0; dp->tx_ring[i].tx_status_tail = DP_TX_COMP_RING_SIZE - 1; dp->tx_ring[i].tx_status = kmalloc(size, GFP_KERNEL); - if (!dp->tx_ring[i].tx_status) + if (!dp->tx_ring[i].tx_status) { + ret = -ENOMEM; goto fail_cmn_srng_cleanup; + } } for (i = 0; i < HAL_DSCP_TID_MAP_TBL_NUM_ENTRIES_MAX; i++)