Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3871227ybz; Tue, 28 Apr 2020 01:45:16 -0700 (PDT) X-Google-Smtp-Source: APiQypJwJT+PDo7sRAz6Al4N4tPP6s49CPit2Dy1T4enNYS8plcNDCibPEp81sElxwmi3c+WQQqY X-Received: by 2002:a17:906:9494:: with SMTP id t20mr22635580ejx.51.1588063516308; Tue, 28 Apr 2020 01:45:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588063516; cv=none; d=google.com; s=arc-20160816; b=W04SV1JP0y9jtZTluVr8BzXd5WepBiwdrhJ51Vza8mC+y8Qo8oqGHk+yGR2gaLXC97 csIv2O0Wn6pPnL5S2yuqUJqdn0cl6daSY72o+yk3OBEmQDKAk7Y1h9a5Kj7T7rpEHAtw uS+ztin5AN9QoJ4uRULHUwHJfYIkjeNKY92pxPd18PZ5T0FN84WRUu+haJYmv7Bh5+Ti mKoDJWS8GF24vN4Z4AG8AM9+vXOPIl1zTtPBkpjYPUVhKDPZKvwwLLKHpUazqVe52/yZ 2qHFU2hs6Ifr25FsffXXLB6xOodBDjXPR18Xx5OuV3xS9NIeIo9td00GhrURLJOAsq8V XT/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature; bh=ZSNSGLztqx/bFT9D2SAH7xK3Gx1la+nBonDVvy1XqhI=; b=DziUeqC0IJS9/7/GA2J7P53SsoAdDxttDES+0kVP0t2nghTacIdEsa5LP+ajfUuas7 GBFN9Duy2JQ2IZ3pZDnu+ZARQ3tkyrydPQlO9OxvHBxoOM0dKSqZ0CnPQAh1e/b9DIvw maLq4sP1gMJs+roVGPkZ03ptOzpAzwZdx5MDEdEkEzYMG33fz1rp4AtMp7Qtsja4h6kP uCJjX96QnJALtAQqsCkY5YphhGxdt3+HkFvD9tKON+b1EAEgMY+6qrEaGyJWDtRK6+mw ZSg9rudn8s+ZJvFwZDivwbhUXUOXsi5Nka5MaV1dEo6wCkADcWjrtrYoIJOuVEqGDEe1 082g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=KbQTi5AR; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r21si1584928eju.300.2020.04.28.01.44.51; Tue, 28 Apr 2020 01:45:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=KbQTi5AR; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726772AbgD1Iov (ORCPT + 99 others); Tue, 28 Apr 2020 04:44:51 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:44036 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726641AbgD1Iou (ORCPT ); Tue, 28 Apr 2020 04:44:50 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1588063490; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=ZSNSGLztqx/bFT9D2SAH7xK3Gx1la+nBonDVvy1XqhI=; b=KbQTi5ARvi8ZTcRJh+Cseey0S16MP/QchIlaJE3P7KCDN7er2IcYVZx5qgYlKA3/QLCAuVI6 RvR+RWjCG9yuCRpzZnhdxWKgZhJEKEUGVG2qdm8ZZoNUuGuqlk/h119X9pUEjTrruKr6G7PX XS3d0oIwqJCKaUhsZa7fMw+TZ7g= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5ea7ed01.7f01ed655490-smtp-out-n03; Tue, 28 Apr 2020 08:44:49 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 7D63BC433F2; Tue, 28 Apr 2020 08:44:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.5 required=2.0 tests=ALL_TRUSTED,MISSING_DATE, MISSING_MID,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 56D14C433CB; Tue, 28 Apr 2020 08:44:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 56D14C433CB Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] rtw88: fix sparse warnings for download firmware routine From: Kalle Valo In-Reply-To: <20200424101255.28239-1-yhchuang@realtek.com> References: <20200424101255.28239-1-yhchuang@realtek.com> To: Cc: User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20200428084448.7D63BC433F2@smtp.codeaurora.org> Date: Tue, 28 Apr 2020 08:44:48 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org wrote: > From: Yan-Hsuan Chuang > > sparse warnings: (new ones prefixed by >>) > > >> drivers/net/wireless/realtek/rtw88/mac.c:653:5: sparse: sparse: > symbol '__rtw_download_firmware' was not declared. Should it be static? > >> drivers/net/wireless/realtek/rtw88/mac.c:817:5: sparse: sparse: > symbol '__rtw_download_firmware_legacy' was not declared. Should it be > static? > > Fixes: 15d2fcc6b2de ("rtw88: add legacy firmware download for 8723D devices") > Reported-by: kbuild test robot > Signed-off-by: Yan-Hsuan Chuang Patch applied to wireless-drivers-next.git, thanks. 3d8bf50860c7 rtw88: fix sparse warnings for download firmware routine -- https://patchwork.kernel.org/patch/11507425/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches