Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3911024ybz; Tue, 28 Apr 2020 02:29:21 -0700 (PDT) X-Google-Smtp-Source: APiQypIbrRlKbRhKHsezEvnj8ak1D1gEbRIURlG3bpcWzOsgblQbWja1952TxHHyHkdRs+39JwZN X-Received: by 2002:a17:906:af94:: with SMTP id mj20mr22917719ejb.347.1588066161234; Tue, 28 Apr 2020 02:29:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588066161; cv=none; d=google.com; s=arc-20160816; b=eaH24SvwSFK/0gTtc13xFBnxaTxe3c7TWEAkGI8DSUxUGBBzxfQ2H4YqRLx1484cCq xXeF3EczOiYhPPeqhJ2FsSlc60aES1QykRL9LaoHB/BhFsNoYK0b0LZOGE8E2AufAcvl TzaPEPpPLtj5yRniRQ7v6rFtKT0+6aHkMv40qClJ6wfopKbraRHrbCGG2nQfaN0/zMNn W8aS/WtluqxdSMI89aZZnyNs5voyhrdqWU23Bi9Dncb1GslEwweOn7VHG23aUI01hYcr zbGXkOVRUI/QVERn+JP7pblqCIGBpnSgQ9xE4f4R5WapKwmWnOwxruDSC95kGDUb+HFb qctw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature; bh=P4VZX3ZX9bjFPFi5wqqFiuPyQ1zJ6+2LvNTJNZrdILk=; b=HfEDFerYHNs5aDQHHQ5BYGZG1YkEAgYk13akfTKKrhzZiMCvbq/tI5wPCSC9Oeb1ET C0UtowohBLTWQ9eLJysQrHiSivnLmP3FueeDtLoa892ftUXhe0FvmrzoUQDXx+VndYm4 HEzx29EVuDVAFLaCwb41ZNkLRX7hx1AR2jRCGobKEfq/07wsEL1e2hmskAbq4alqleC9 IGTHH4hSW3TqtgUCrRRZoJF8o2VwyevA7W3vpmy7xXtlgb9w6J9p1jEqcOZPohbYCyRJ LsQSrvUCzmJFARj5Qm/ebhmQ+AQApQhnZoYmTgeXXL/P3Wc1trJqlp51yYdb3oD5/UZw iKFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=QmncEyJK; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id yc9si1330376ejb.319.2020.04.28.02.28.49; Tue, 28 Apr 2020 02:29:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=QmncEyJK; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727078AbgD1J2R (ORCPT + 99 others); Tue, 28 Apr 2020 05:28:17 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:46637 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727052AbgD1J2R (ORCPT ); Tue, 28 Apr 2020 05:28:17 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1588066096; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=P4VZX3ZX9bjFPFi5wqqFiuPyQ1zJ6+2LvNTJNZrdILk=; b=QmncEyJKKgqeqB5C3j810EDwIEPXfQB9Hx8wLUsXvOOZUrjJdCORoxVoTt4LuZFr11i2o/T7 kv5XGX54gJc1mLaSbSHG55aUl0AZqHHmAj7FxL21aP8GwU/lRfYGfDEbn97/uS1/nQbFlwAt 9T2ktT3iZwoMZhrUmqBnQlojUE0= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5ea7f721.7f3ee3d93308-smtp-out-n03; Tue, 28 Apr 2020 09:28:01 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 224E1C433F2; Tue, 28 Apr 2020 09:28:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.5 required=2.0 tests=ALL_TRUSTED,MISSING_DATE, MISSING_MID,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 3CEA2C433D2; Tue, 28 Apr 2020 09:27:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 3CEA2C433D2 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH net-next] ath11k: remove redundant dev_err call in ath11k_ahb_probe() From: Kalle Valo In-Reply-To: <20200427104403.14598-1-weiyongjun1@huawei.com> References: <20200427104403.14598-1-weiyongjun1@huawei.com> To: Wei Yongjun Cc: Wei Yongjun , , , User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20200428092801.224E1C433F2@smtp.codeaurora.org> Date: Tue, 28 Apr 2020 09:28:01 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Wei Yongjun wrote: > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Signed-off-by: Wei Yongjun I don't see harm having two error messages and having an error message within ath11k makes it easier to find the exact location, so I'm dropping this. -- https://patchwork.kernel.org/patch/11511845/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches