Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3931098ybz; Tue, 28 Apr 2020 02:51:31 -0700 (PDT) X-Google-Smtp-Source: APiQypLllFUR5pHLMLRUmSRkKOMJEKSO8+7yh5n4t3AlGn0Bzx6rMee6/THLqOW4uehzcAaRR26D X-Received: by 2002:aa7:cd08:: with SMTP id b8mr21117685edw.96.1588067491313; Tue, 28 Apr 2020 02:51:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588067491; cv=none; d=google.com; s=arc-20160816; b=q37Qr+PTvVw22LVUowFaPbwVfrDdMRvX8+qMiM4qdT7VuABu+T8t4RJzpDooInRfbX /7WKOssg1EPBoRdYd/W2fJDzmCyPECPU/jZVUI9Z7joNmrRL02moeWdH40EsNVKiMl2C RGJleM5AxGf6GWwEj9lBK2Tq1K88y7/72ntumiRD6CYEm98OkcIku/VWcrIrMMby2/xV riKz31anJlh33IcnVyZh8B2lu/nnbqmuoChKay2dboYj0hRLv7HcSraIKwIriWTVI+WU xl4qC/y+c8rSWcGP8hTkMXjnqw+Ymtzz3SIxVfTLxyfdaxH8f92G0YBsa1CmiU97eaSe baVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:message-id:references :in-reply-to:subject:cc:to:from:date:content-transfer-encoding :mime-version:dkim-signature; bh=Ot1JE8mGrLeKXjW9jNRp/7RM3Thoh3OD95x4qaOK1m4=; b=ciSOgRdeGtxHXXR87lGQ0FsPE2JDc7Z/2Xtx2C/4a2IJVTUVdTxL3AC/SiufruiH+4 4eJd7ZoKZKjemY9qEx1oPUMgWlJpBHZJe4BTpXTh2J2KlcID6Odi+C/SLMJFTFt4gc8W QKbiTF5h0738l4qSt7SZsbz4R3AwGXGnVb/TesIY1TGIRUyK20vh54MmppWn2V1XeY4X IGRfuy+6Ptydhk4tYAjZ9yw0H0pHjaEqvP/WeKYx4f2hE7pvTwd1dk4fjvnrUs5Ikc8z bTeSq5POqgFRj+VL3TAlTwT3FlDIbY3nnTd7AlKTMhFLkoRMfHPEN1nK3RqsUmuEfGA9 6SDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=KUkslRvk; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n18si1481444ejr.305.2020.04.28.02.51.02; Tue, 28 Apr 2020 02:51:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=KUkslRvk; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727779AbgD1Jtr (ORCPT + 99 others); Tue, 28 Apr 2020 05:49:47 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:46700 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727030AbgD1Jtq (ORCPT ); Tue, 28 Apr 2020 05:49:46 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1588067385; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=Ot1JE8mGrLeKXjW9jNRp/7RM3Thoh3OD95x4qaOK1m4=; b=KUkslRvksO4MAaaoOjIuGMNl2K9p3idQ721eQOnCHUHvHojSxGloIxQQid5HPUmTjrk2oEED Aoil8WA8NjRex2BEMznHAOyfIwEFghqe8fRo8+8or52isIyLGKdMixuSBXdhY/Jp+rz4AXCl IeUguzDTdoiiBZnmi6IKmsIQzH8= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5ea7fc28.7fb55e111ea0-smtp-out-n02; Tue, 28 Apr 2020 09:49:28 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id AEF25C433F2; Tue, 28 Apr 2020 09:49:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: wgong) by smtp.codeaurora.org (Postfix) with ESMTPSA id 28260C433D2; Tue, 28 Apr 2020 09:49:27 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 28 Apr 2020 17:49:27 +0800 From: Wen Gong To: Kalle Valo Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Subject: Re: [PATCH v2 1/4] ath10k: enable firmware peer stats info for wmi tlv In-Reply-To: <87k120eyyl.fsf@kamboji.qca.qualcomm.com> References: <20200427080416.8265-2-wgong@codeaurora.org> <20200428091303.089AEC433D2@smtp.codeaurora.org> <87k120eyyl.fsf@kamboji.qca.qualcomm.com> Message-ID: <2c0d03590f2ecf55aaff86e760232807@codeaurora.org> X-Sender: wgong@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2020-04-28 17:33, Kalle Valo wrote: > Kalle Valo writes: > >> Wen Gong wrote: >> >>> For wmi tlv type, firmware disable peer stats info by default, after >>> enable it, firmware will report WMI_TLV_PEER_STATS_INFO_EVENTID if >>> ath10k send WMI_TLV_REQUEST_PEER_STATS_INFO_CMDID to firmware. >>> >>> Enable it will only set a flag in firmware, firmware will not report >>> it without receive request WMI command. >>> >>> Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00042. >>> >>> Signed-off-by: Wen Gong >>> Signed-off-by: Kalle Valo >> >> 4 patches applied to ath-next branch of ath.git, thanks. >> >> 2289bef25e32 ath10k: enable firmware peer stats info for wmi tlv >> 0f7cb26830a6 ath10k: add rx bitrate report for SDIO >> 3344b99d69ab ath10k: add bitrate parse for peer stats info >> 4cc02c7c1494 ath10k: correct tx bitrate of iw for SDIO > > I think these caused a new warning which I missed: > > drivers/net/wireless/ath/ath10k/wmi-tlv.c:3013:34: warning: incorrect > type in assignment (different base types) > drivers/net/wireless/ath/ath10k/wmi-tlv.c:3013:34: expected > restricted __le32 [usertype] reset_after_request > drivers/net/wireless/ath/ath10k/wmi-tlv.c:3013:34: got unsigned int > [usertype] reset ok. I will give new patch to fix the 3 warning. > > Please send a followup patch to fix that.