Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A921EC433CB
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Lorenzo Bianconi <lorenzo@kernel.org>
Cc:     nbd@nbd.name, linux-wireless@vger.kernel.org,
        lorenzo.bianconi@redhat.com, sean.wang@mediatek.com,
        linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] mt76: mt7663: add the possibility to load firmware v2
References: <db72b648024aba3243ee3b7deceb548c9bc2bdf1.1587911939.git.lorenzo@kernel.org>
Date:   Tue, 28 Apr 2020 14:07:49 +0300
In-Reply-To: <db72b648024aba3243ee3b7deceb548c9bc2bdf1.1587911939.git.lorenzo@kernel.org>
        (Lorenzo Bianconi's message of "Sun, 26 Apr 2020 16:40:18 +0200")
Message-ID: <87ftcnj2be.fsf@tynnyri.adurom.net>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Lorenzo Bianconi <lorenzo@kernel.org> writes:

> mt7663 firmware v2 is used for embedded devices since it has more completed
> features in AP mode.
> Add the capability to specify in mt7615 Kconfig which firmware load first
> (v3 or v2) and fallback to the other one if the selected firmware fails
> to load
>
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
>  .../net/wireless/mediatek/mt76/mt7615/Kconfig | 13 +++++
>  .../net/wireless/mediatek/mt76/mt7615/mcu.c   | 50 ++++++++++++++++---
>  .../wireless/mediatek/mt76/mt7615/mt7615.h    |  6 ++-
>  .../net/wireless/mediatek/mt76/mt7615/pci.c   |  2 +
>  .../net/wireless/mediatek/mt76/mt7615/usb.c   |  2 +
>  5 files changed, 65 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/Kconfig b/drivers/net/wireless/mediatek/mt76/mt7615/Kconfig
> index e25db1135eda..c04d6a182bf0 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7615/Kconfig
> +++ b/drivers/net/wireless/mediatek/mt76/mt7615/Kconfig
> @@ -38,3 +38,16 @@ config MT7663U
>  	  This adds support for MT7663U 802.11ax 2x2:2 wireless devices.
>  
>  	  To compile this driver as a module, choose M here.
> +
> +config MT7615_OFFLOAD_FIRMWARE
> +	bool "Prefer client mode offload firmware (MT7663)"
> +	depends on MT7615E || MT7663U
> +	default y
> +	help
> +	  Load MT7663 client mode offload firmware (v3) as primary option
> +	  and fallback to MT7663 firmware v2 in case of failure.
> +	  If MT7615_OFFLOAD_FIRMWARE is not selected MT7663 firmware v2
> +	  will be used as primary option.
> +	  MT7663 client mode offload firmware supports low power features
> +	  (hw frequency scanning, scheduled frequency scanning, WoW,
> +	  802.11 power save) but is more limited in AP mode

Why does this need a compile time config? Wouldn't some kind of runtime
configuration be better?

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches