Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp945548ybz;
        Wed, 29 Apr 2020 12:11:54 -0700 (PDT)
X-Google-Smtp-Source: APiQypIdruNhfzXhYikHgz5ub5dDU6djNpwBvQjut/DhA+sERVPf/9udpUvmzPWyrGMVPoh0fxQN
X-Received: by 2002:a17:907:20ce:: with SMTP id qq14mr3961573ejb.10.1588187514530;
        Wed, 29 Apr 2020 12:11:54 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1588187514; cv=none;
        d=google.com; s=arc-20160816;
        b=G5IztxYX0C6Qzt/KRpOiTAx9TKvBIEiZ93DHV0g6ucZCO0Bd5atf2oRNju6jXN+jW1
         PUxJ5dlDLPMtyZlQ0l8k6KAgi06xfDXdYP8sPrd9XtP2LJ9tM2w+Jqt9AXP4mIOFD/lc
         rp8ZuJ3OfoHHExuONLmgIdltiZV0srrCNlQyVLNpUtwaiMA+Yw91Va3Fd8/hwP74ufc1
         xFmPogk5OiE8eZ4JLMGvCe8TRdgEkLf5WeWprpcZCORhbkOKSJPuZJHyu8lDDhDloJcE
         fvX5gRc0MaCSVIioFO4ePEoQh9l9aPL1jP6t/hdInz6AevgxnVDtR4XGPHOZVQkqnGPO
         7NYA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:from:subject:cc:to:message-id:date;
        bh=kw+X/NQpvMFu+RrFOQaaBppIa8OIntVRFrSHPYYAF/s=;
        b=PkI68ISGIhzO2fS+WI+9tHwmT//eu0zi0kk8VKOy3yZiWqDqjykWTbOnsVQjjxetUT
         16rTzEzyJALk5RF0ok0otbSRYzHpqz6tqq9fcIA2Us7cwDXJCO6L6a1NS3/z2U9eyNKt
         Iq1yovbBM64baweymJSnLsQSZa5eSVVH65P7H+PmOxPRus5/us1KjkjPl/LrFiBhcszp
         i/lvFWXy6CAszMdteOLwkJ/V9IEjUBidrtR8p0pO56SCFZ4QwaeVqRepnBn2xN3kcb8p
         fLk+fLg2C/xPaNbjy5Nm9FWkSta26QpnmsF6rFQy2PJyOwYWn+ZVkQU5W+J7UazU7Vfn
         Wtiw==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org
Return-Path: <linux-wireless-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id s8si4346863edr.485.2020.04.29.12.11.17;
        Wed, 29 Apr 2020 12:11:54 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726885AbgD2TLE (ORCPT <rfc822;hejilao2020@gmail.com>
        + 99 others); Wed, 29 Apr 2020 15:11:04 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49222 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL)
        by vger.kernel.org with ESMTP id S1726456AbgD2TLE (ORCPT
        <rfc822;linux-wireless@vger.kernel.org>);
        Wed, 29 Apr 2020 15:11:04 -0400
Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F741C03C1AE;
        Wed, 29 Apr 2020 12:11:04 -0700 (PDT)
Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id D92C91210A3E3;
        Wed, 29 Apr 2020 12:11:03 -0700 (PDT)
Date:   Wed, 29 Apr 2020 12:11:03 -0700 (PDT)
Message-Id: <20200429.121103.1627116280946095444.davem@davemloft.net>
To:     johannes@sipsolutions.net
Cc:     netdev@vger.kernel.org, ordex@autistici.org,
        linux-wireless@vger.kernel.org
Subject: Re: [PATCH 0/7] netlink validation improvements/refactoring
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20200429134843.42224-1-johannes@sipsolutions.net>
References: <20200429134843.42224-1-johannes@sipsolutions.net>
X-Mailer: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 29 Apr 2020 12:11:04 -0700 (PDT)
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

From: Johannes Berg <johannes@sipsolutions.net>
Date: Wed, 29 Apr 2020 15:48:36 +0200

> Sorry - again, I got distracted/interrupted before I could send this.
> I made this a little more than a year ago, and then forgot it. Antonio
> asked me something a couple of weeks ago, and that reminded me of this
> so I'm finally sending it out now (rebased & adjusted).
> 
> Basically this just does some refactoring & improvements for range
> validation, leading up to a patch to expose the policy to userspace,
> which I'll send separately as RFC for now.

Please fix the pt->min/pt->max WARN_ON() vs. range pointer issue that
Jakub pointed out.

Otherwise this series looks good.