Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Wed, 29 Apr 2020 17:04:51 -0700
From:   Rajkumar Manoharan <rmanohar@codeaurora.org>
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     linux-wireless@vger.kernel.org
Subject: Re: [PATCH 03/10] nl80211: add HE 6 GHz Band Capability support
In-Reply-To: <56500fd2b7c6b54e904567ba27171542027f2aea.camel@sipsolutions.net>
References: <1587768108-25248-1-git-send-email-rmanohar@codeaurora.org>
 <1587768108-25248-4-git-send-email-rmanohar@codeaurora.org>
 <56500fd2b7c6b54e904567ba27171542027f2aea.camel@sipsolutions.net>
Message-ID: <92e6776c460982184b3d8077a4a3cc1a@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 2020-04-29 07:28, Johannes Berg wrote:
> On Fri, 2020-04-24 at 15:41 -0700, Rajkumar Manoharan wrote:
>> Define new structures for HE 6 GHz band capabilities as per
> 
> per?
> 
Oops.. My bad. Accidentally removed the commit log.

>>  include/linux/ieee80211.h    | 57 
>> ++++++++++++++++++++++++++++++++++++++++++++
>>  include/net/cfg80211.h       |  2 ++
>>  include/uapi/linux/nl80211.h |  6 +++++
>>  net/wireless/nl80211.c       | 14 +++++++++++
> 
> This is a bit mixed up, I'd prefer the raw ieee80211.h definitions in a
> separate patch.
> 
Sure.

>> +	[NL80211_ATTR_HE_6GHZ_CAPABILITY] = {
>> +		.type = NLA_EXACT_LEN_WARN,
>> +		.len = NL80211_HE_6GHZ_CAPABILITY_LEN,
>> +	},
> 
> Shouldn't use _WARN for a new attribute. Just reject it if userspace
> gets it wrong.
> 
Done. :)

>> @@ -6177,6 +6185,12 @@ static int nl80211_new_station(struct sk_buff 
>> *skb, struct genl_info *info)
>>  			return -EINVAL;
>>  	}
>> 
>> +	/* Ensure that HT/VHT capabilities are not set for 6 GHz HE STA */
>> +	if (params.he_6ghz_capa) {
>> +		params.ht_capa = NULL;
>> +		params.vht_capa = NULL;
>> +	}
> 
> IMHO better to reject (with a message)
> 
Got it.

-Rajkumar