Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Wed, 29 Apr 2020 17:11:24 -0700
From:   Rajkumar Manoharan <rmanohar@codeaurora.org>
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     linux-wireless@vger.kernel.org
Subject: Re: [PATCH 05/10] mac80211: handle HE 6 GHz Capability in HE STA
 processing
In-Reply-To: <8e55825d2c399dc926dacdc799fc64851d2fc4fb.camel@sipsolutions.net>
References: <1587768108-25248-1-git-send-email-rmanohar@codeaurora.org>
 <1587768108-25248-6-git-send-email-rmanohar@codeaurora.org>
 <8e55825d2c399dc926dacdc799fc64851d2fc4fb.camel@sipsolutions.net>
Message-ID: <a555a6cd27c5b100d2d11804c5b387de@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 2020-04-29 07:31, Johannes Berg wrote:
> On Fri, 2020-04-24 at 15:41 -0700, Rajkumar Manoharan wrote:
>> 
>>   * @has_he: true iff HE data is valid.
>> + * @has_he_6ghz: true iff HE 6 GHz data is valid.
>>   * @he_cap_elem: Fixed portion of the HE capabilities element.
>>   * @he_mcs_nss_supp: The supported NSS/MCS combinations.
>>   * @ppe_thres: Holds the PPE Thresholds data.
>> + * @ampdu_factor: Maximum A-MPDU length factor used in 6 GHz.
>> + * @ampdu_density: Minimum A-MPDU spacing used in 6 GHz.
>> + * @he_6gz_cap: HE 6 GHz Band capability.
> 
> typo
> 
>>   */
>>  struct ieee80211_sta_he_cap {
>>  	bool has_he;
>> +	bool has_he_6ghz;
>>  	struct ieee80211_he_cap_elem he_cap_elem;
>>  	struct ieee80211_he_mcs_nss_supp he_mcs_nss_supp;
>>  	u8 ppe_thres[IEEE80211_HE_PPE_THRES_MAX_LEN];
>> +	u8 ampdu_factor;
>> +	u8 ampdu_density;
>> +	u16 he_6ghz_cap;
> 
> Maybe these should be in some kind of sub-struct so it's clear what the
> "has_he_6ghz" applies to?
> 
Got it.

>>  };
>> 
>>  /**
>> @@ -1272,7 +1280,7 @@ struct station_parameters {
>>  	u8 he_capa_len;
>>  	u16 airtime_weight;
>>  	struct sta_txpwr txpwr;
>> -	const struct ieee80211_he_6ghz_band_cap *he_6ghz_capa;
>> +	const u8 *he_6ghz_capa;
> 
> hm?
> 

I realized later ;) that ieee80211_he_cap_ie_to_sta_he_cap accepting u8* 
for IEs.
To align with the existing pattern changed to u8 *. Let me correct it 
first.

-Rajkumar