Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 560B7C43636
From:   Kalle Valo <kvalo@codeaurora.org>
To:     John Crispin <john@phrozen.org>
Cc:     Johannes Berg <johannes@sipsolutions.net>,
        Miles Hu <milehu@codeaurora.org>,
        linux-wireless@vger.kernel.org, ath11k@lists.infradead.org
Subject: Re: [PATCH V3 3/3] ath11k: add support for setting fixed HE rate/gi/ltf
References: <20200429145708.25992-1-john@phrozen.org>
        <20200429145708.25992-3-john@phrozen.org>
Date:   Thu, 30 Apr 2020 11:46:16 +0300
In-Reply-To: <20200429145708.25992-3-john@phrozen.org> (John Crispin's message
        of "Wed, 29 Apr 2020 16:57:08 +0200")
Message-ID: <877dxxfjjb.fsf@kamboji.qca.qualcomm.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

John Crispin <john@phrozen.org> writes:

> From: Miles Hu <milehu@codeaurora.org>
>
> This patch adds ath11k support for setting fixed HE rate/gi/ltf values that
> we are now able to send to the kernel using nl80211. The added code is
> reusing parts of the existing code path already used for HT/VHT. The new
> helpers are symmetric to how we do it for HT/VHT.
>
> Signed-off-by: Miles Hu <milehu@codeaurora.org>
> Signed-off-by: John Crispin <john@phrozen.org>

[...]

> +		if (he_ltf != 0xFF) {
> +			vdev_param = WMI_VDEV_PARAM_HE_LTF;
> +				/* start from 1 */
> +				he_ltf += 1;

Indentation looks weird here, but I can fix that during commit.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches