Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1174720ybz; Fri, 1 May 2020 16:18:38 -0700 (PDT) X-Google-Smtp-Source: APiQypJBEU0XXOUnxUDAkydDCiwCxYccORDttWQvUL+VDed7/iQLq9My878xwxWmBoP3rU5KCPDm X-Received: by 2002:a17:907:42d6:: with SMTP id ng6mr5339389ejb.265.1588375118694; Fri, 01 May 2020 16:18:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588375118; cv=none; d=google.com; s=arc-20160816; b=jHY5A1LvbJQczDybfXMJM1NhVOAIN75WtkumVcWMmhGo/TMMB1jy+NDq4672vImiyI 2201lEzt5RmxJh1+k6e8P5texw8EVmKE3NSbbgfMiLMBWW7J2O4PSkFcN5YmSMsqlYS/ rKuIiT+NKImPPy95iI/ZekbiFWscwSF0tM3rr4tWmXYIyRiwDm+tpLyYGulCahitC31w JSmFDt21VWKAFbXx0hgqM4o6LZFyC0YjqK5hYJtltygF3zWsA7TDvEPeMLj5rC3Xn9Wb BftPRfn5Y+RmxH6Fm88KZ6oNc6SAFmFm0VJ88XPxkVbMKv2w0cHxxlQNgtqCgRWSP1vB rO+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=zmUHN7PWTGchaBWJ/FletfBCCB0fOBsF6kHHWnOQ+R0=; b=1BUTEDJ0aLlUfwyQXNa0YfOhnNmuoGrGXAC0h0f7gvnAW3MuF5oiMXr1WmonbgBmEz qzVLKUgmHx54aIXe8FkEvCSXjx3sMqeQuICjnqPSrIyPnrYYhEXooaU4f0MAaFXsVSJk hFiX3w6eiUnG9BXpEjdswimWH+8kQEuIYlcMbcXWbgnGwF1pzGESCBR0RsESwFDJUkzk RGa8uVr7Mb4ObCdxBYaf/lUy/eGxFkRINUZ6AdGczFWDEmXa6g5Ev6HPU9hVa8LwEIxS bzgtGh8T0lJVCFmRDHKTT4/dIbMP/UpZh+hoSf3n7me3mY1uZBhCBsGcN6FKLsffrdkF o3iQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=I9SbjvAT; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c3si2517844eja.251.2020.05.01.16.18.15; Fri, 01 May 2020 16:18:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=I9SbjvAT; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726333AbgEAXQ2 (ORCPT + 99 others); Fri, 1 May 2020 19:16:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:57614 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726045AbgEAXQ1 (ORCPT ); Fri, 1 May 2020 19:16:27 -0400 Received: from lore-desk.lan (unknown [151.48.155.206]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 493082166E; Fri, 1 May 2020 23:16:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588374987; bh=JHOG9KXVITuJTdpFdkSLOpp47cYOYsV+QxiylIY+xKw=; h=From:To:Cc:Subject:Date:From; b=I9SbjvATWIH8jx0N85OZ4wZL5di1wR5F8TINRQNB5/7LFfVt8657J/x3bdkW+/qeM qV2LrlgNFEBNwop4pZAtIpF9nQTorne2FQCDx8hPVilL1rCkCeJSjGHSSNYpTQ9O0C mAPg487HF7mEVPwzVLQ3zU+8Bl8/QLGbgWUEAvNA= From: Lorenzo Bianconi To: nbd@nbd.name Cc: linux-wireless@vger.kernel.org, lorenzo.bianconi@redhat.com, sean.wang@mediatek.com, linux-mediatek@lists.infradead.org Subject: [PATCH] mt76: mt7615: check return value of mt7615_eeprom_get_power_index Date: Sat, 2 May 2020 01:16:10 +0200 Message-Id: <9f2e5027dec463c32c29b6047eb3250e20389d1f.1588374866.git.lorenzo@kernel.org> X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org mt7615_eeprom_get_power_index can return negative error value. Check mt7615_eeprom_get_power_index return value before using it Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/mt7615/init.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/init.c b/drivers/net/wireless/mediatek/mt76/mt7615/init.c index 81294bb2b06b..d831d647d237 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7615/init.c +++ b/drivers/net/wireless/mediatek/mt76/mt7615/init.c @@ -247,6 +247,9 @@ void mt7615_init_txpower(struct mt7615_dev *dev, int index; index = mt7615_eeprom_get_power_index(dev, chan, j); + if (index < 0) + continue; + target_power = max(target_power, eep[index]); } -- 2.25.4