Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 3 May 2020 09:32:33 +0200
From:   Oscar Carter <oscar.carter@gmx.com>
To:     Ajay.Kathat@microchip.com
Cc:     oscar.carter@gmx.com, adham.abozaeid@microchip.com,
        gregkh@linuxfoundation.org, rachel.kim@atmel.com,
        johnny.kim@atmel.com, chris.park@atmel.com, dean.lee@atmel.com,
        linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: wilc1000: Increase the size of wid_list array
Message-ID: <20200503073232.GA3228@ubuntu>
References: <20200501170239.16917-1-oscar.carter@gmx.com>
 <555a8486-8a9f-44a6-3423-78981955765a@microchip.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <555a8486-8a9f-44a6-3423-78981955765a@microchip.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Content-Transfer-Encoding: quoted-printable
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Fri, May 01, 2020 at 06:26:10PM +0000, Ajay.Kathat@microchip.com wrote:
>
> On 01/05/20 10:32 pm, Oscar Carter wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know=
 the content is safe
> >
> > Increase by one the size of wid_list array as index variable can reach=
 a
> > value of 5. If this happens, an out-of-bounds access is performed.
> >
> > Addresses-Coverity-ID: 1451981 ("Out-of-bounds access")
> > Fixes: c5c77ba18ea66 ("staging: wilc1000: Add SDIO/SPI 802.11 driver")
>
> The code changes are fine. But the correct commit for Fixes tag should b=
e
>
> Fixes: f5a3cb90b802d ("staging: wilc1000: add passive scan support")
>
Sorry for the mistake. I will make the change and I will send a new versio=
n.
>
> Regards,
> Ajay
>
> > Signed-off-by: Oscar Carter <oscar.carter@gmx.com>
> > ---
> >  drivers/staging/wilc1000/hif.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/wilc1000/hif.c b/drivers/staging/wilc1000=
/hif.c
> > index 6c7de2f8d3f2..128943c3be4f 100644
> > --- a/drivers/staging/wilc1000/hif.c
> > +++ b/drivers/staging/wilc1000/hif.c
> > @@ -151,7 +151,7 @@ int wilc_scan(struct wilc_vif *vif, u8 scan_source=
, u8 scan_type,
> >               void *user_arg, struct cfg80211_scan_request *request)
> >  {
> >         int result =3D 0;
> > -       struct wid wid_list[5];
> > +       struct wid wid_list[6];
> >         u32 index =3D 0;
> >         u32 i, scan_timeout;
> >         u8 *buffer;
> > --
> > 2.20.1
> >
Thanks,
Oscar