Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authenticated-By: 
From:   Tony Chuang <yhchuang@realtek.com>
To:     Dejin Zheng <zhengdejin5@gmail.com>,
        "kvalo@codeaurora.org" <kvalo@codeaurora.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "sgruszka@redhat.com" <sgruszka@redhat.com>,
        "briannorris@chromium.org" <briannorris@chromium.org>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Andy Shevchenko" <andy.shevchenko@gmail.com>
Subject: RE: [PATCH net v1] net: rtw88: fix an issue about leak system resources
Thread-Topic: [PATCH net v1] net: rtw88: fix an issue about leak system
 resources
Thread-Index: AQHWIe7inKq7KGzTFUK74b0Sl3+N96iXmmBw
Date:   Mon, 4 May 2020 08:37:15 +0000
Message-ID: <88e6cc654a73472f9591fb0c6b74f768@realtek.com>
References: <20200504083442.3033-1-zhengdejin5@gmail.com>
In-Reply-To: <20200504083442.3033-1-zhengdejin5@gmail.com>
Accept-Language: zh-TW, en-US
Content-Language: zh-TW
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

> Subject: [PATCH net v1] net: rtw88: fix an issue about leak system resources
> 
> the related system resources were not released when pci_iomap() return
> error in the rtw_pci_io_mapping() function. add pci_release_regions() to
> fix it.
> 
> Fixes: e3037485c68ec1a ("rtw88: new Realtek 802.11ac driver")
> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com>
Acked-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
> ---
>  drivers/net/wireless/realtek/rtw88/pci.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/wireless/realtek/rtw88/pci.c
> b/drivers/net/wireless/realtek/rtw88/pci.c
> index 695c2c0d64b0..a9752c34c9d8 100644
> --- a/drivers/net/wireless/realtek/rtw88/pci.c
> +++ b/drivers/net/wireless/realtek/rtw88/pci.c
> @@ -1102,6 +1102,7 @@ static int rtw_pci_io_mapping(struct rtw_dev
> *rtwdev,
>  	len = pci_resource_len(pdev, bar_id);
>  	rtwpci->mmap = pci_iomap(pdev, bar_id, len);
>  	if (!rtwpci->mmap) {
> +		pci_release_regions(pdev);
>  		rtw_err(rtwdev, "failed to map pci memory\n");
>  		return -ENOMEM;
>  	}
> --
> 2.25.0