Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3422928ybz; Mon, 4 May 2020 02:41:39 -0700 (PDT) X-Google-Smtp-Source: APiQypLt2Paykb48occSsHlsdast2xY+Yxy3LAPUj0DRnkcz7RVYEXfjsiyShMnNlFI6YLbe/KsT X-Received: by 2002:aa7:cd7c:: with SMTP id ca28mr13830547edb.181.1588585299338; Mon, 04 May 2020 02:41:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588585299; cv=none; d=google.com; s=arc-20160816; b=kWCnnfAh9Yzl4oRj+1rPuVeyv6aDUMOemloEe6eMQ0RrO9rOBegR+nlmt9m0a3jpEN akP1ymIAwXgF2Nd1PugJt6tTs3/l1NkDDR2AAfDYuDSUJZfBW3siGEZlKBOaXUbYfOro /Ks+Ht9VbPtqM2LnnCy0ayNNtwbaNu+xymQRMbhoQ8eHq3SVdDMFHHouIC4/p7PB1E3Z CVTluSJuxhoCetO3rXujtE6AlTzsrtxxti3a1sxZXNuzbZWudbhbRZH61qWX0tMi2uLF jEJ4C1EenO/XfJZc5NnxwreJo7nFGxBV8JAf0KpJdg2KHfncFFgJR0jnS39xEs86IHte Jq3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature; bh=jvDJv8FHyDjUsVzxPiq5yfDM6HScTqopUDc+IZlUt/s=; b=GF7i/Fibwt3jdpmXB98qkqgGUCzRyNYAxo8Y0LF+KVndYdkwnYj8EDemVp2MMay8KC 9lX+jJ/X6PyksfzOB3Y3HfOxp+5UsD5iV82wGygPetqvoJaR2hovk+mdO42ve8hl/BdD r2jSxI9hm2tdcut9k0lM/JYnCEyIUg9XQNHuZ2JA1ooaWGib90HO6NtnNUW3Zv6JIVoa wLRhW2ph6mUB91ZuLGDIRkjPprqIxtXhUNbUkj/dt4LlyEKWLry+zpxNQId+UZcoTXRx AJIgOL4AmRqNHR9W9Vc4Q/tgu0cBsST2R6hfqpkwMjOm+K4tyUx09inl+vXWDOk5ehDc /+6g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b="A/K2mMoy"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g5si6686833edu.188.2020.05.04.02.41.11; Mon, 04 May 2020 02:41:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b="A/K2mMoy"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728399AbgEDJho (ORCPT + 99 others); Mon, 4 May 2020 05:37:44 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:43399 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726625AbgEDJho (ORCPT ); Mon, 4 May 2020 05:37:44 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1588585063; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=jvDJv8FHyDjUsVzxPiq5yfDM6HScTqopUDc+IZlUt/s=; b=A/K2mMoytfL1uoyG4zT23J5jj6k6HV5ifXwUNRdQ0EVTBhvtfPkS8ioG01NM85Y0ct3wISWK sya3HkUNbx+kvfJMRHln9Fqy1OLnDLSBPYkidusRIrA2AiDoXefMsBdUdUzjbtmZDPf3V2CI fBt72avTReScAy0DHztMHoZ6W5U= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5eafe255.7f7375401d88-smtp-out-n03; Mon, 04 May 2020 09:37:25 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 6FC5EC432C2; Mon, 4 May 2020 09:37:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.5 required=2.0 tests=ALL_TRUSTED,MISSING_DATE, MISSING_MID,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 3F870C433CB; Mon, 4 May 2020 09:37:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 3F870C433CB Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] rtw88: mac: Make some founctions static From: Kalle Valo In-Reply-To: <20200425083503.149656-1-chentao107@huawei.com> References: <20200425083503.149656-1-chentao107@huawei.com> To: ChenTao Cc: , , , , User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20200504093724.6FC5EC432C2@smtp.codeaurora.org> Date: Mon, 4 May 2020 09:37:24 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org ChenTao wrote: > Fix the following warning: > > vers/net/wireless/realtek/rtw88/mac.c:699:5: warning: > symbol '__rtw_download_firmware' was not declared. Should it be static? > drivers/net/wireless/realtek/rtw88/mac.c:863:5: warning: > symbol '__rtw_download_firmware_legacy' was not declared. Should it be static? > > Reported-by: Hulk Robot > Signed-off-by: ChenTao Already fixed: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?id=3d8bf50860c7de09c9713b97ec2f87ad42338c7e -- https://patchwork.kernel.org/patch/11509743/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches