Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 4 May 2020 16:43:13 +0200
From:   Oscar Carter <oscar.carter@gmx.com>
To:     Joe Perches <joe@perches.com>, Ajay.Kathat@microchip.com,
        adham.abozaeid@microchip.com
Cc:     Oscar Carter <oscar.carter@gmx.com>, gregkh@linuxfoundation.org,
        rachel.kim@atmel.com, johnny.kim@atmel.com, chris.park@atmel.com,
        dean.lee@atmel.com, linux-wireless@vger.kernel.org,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: wilc1000: Increase the size of wid_list array
Message-ID: <20200504144313.GA3213@ubuntu>
References: <20200503075145.4563-1-oscar.carter@gmx.com>
 <d75b7f64-0ba0-65e9-ea4c-cc87b3a51a10@microchip.com>
 <d3e07dfd0efe21192d172b2e4e7d4a489a4fcc62.camel@perches.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d3e07dfd0efe21192d172b2e4e7d4a489a4fcc62.camel@perches.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Content-Transfer-Encoding: quoted-printable
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Sun, May 03, 2020 at 04:29:53PM -0700, Joe Perches wrote:
> On Sun, 2020-05-03 at 14:52 +0000, Ajay.Kathat@microchip.com wrote:
> > On 03/05/20 1:21 pm, Oscar Carter wrote:
> > > EXTERNAL EMAIL: Do not click links or open attachments unless you kn=
ow the content is safe
> > >
> > > Increase by one the size of wid_list array as index variable can rea=
ch a
> > > value of 5. If this happens, an out-of-bounds access is performed.
> > >
> > > Addresses-Coverity-ID: 1451981 ("Out-of-bounds access")
> > > Fixes: f5a3cb90b802d ("staging: wilc1000: add passive scan support")
> > > Signed-off-by: Oscar Carter <oscar.carter@gmx.com>
> []
> > > diff --git a/drivers/staging/wilc1000/hif.c b/drivers/staging/wilc10=
00/hif.c
> []
> > > @@ -151,7 +151,7 @@ int wilc_scan(struct wilc_vif *vif, u8 scan_sour=
ce, u8 scan_type,
> > >               void *user_arg, struct cfg80211_scan_request *request)
> > >  {
> > >         int result =3D 0;
> > > -       struct wid wid_list[5];
> > > +       struct wid wid_list[6];
>
> This looks like it should be using a #define instead of
> a hard-coded number.

I agree. I will make the changes you suggested and I will resend a new ver=
sion.

> > >         u32 index =3D 0;
> > >         u32 i, scan_timeout;
> > >         u8 *buffer;
> > > --
> > > 2.20.1
>
Thanks,
Oscar Carter