Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Christian Lamparter <chunkeey@gmail.com>
To:     Kalle Valo <kvalo@codeaurora.org>
Cc:     Frank =?ISO-8859-1?Q?Sch=E4fer?= <fschaefer.oss@googlemail.com>,
        linux-wireless@vger.kernel.org
Subject: Re: [PATCH] carl9170: remove P2P_GO support
Date:   Tue, 05 May 2020 20:31:01 +0200
Message-ID: <27876964.GhbJDmQBxd@debian64>
In-Reply-To: <87368ej1aj.fsf@tynnyri.adurom.net>
References: <20200425092811.9494-1-chunkeey@gmail.com> <5ebf8e6d-d34b-aa92-d166-d8a5ca0b2c18@googlemail.com> <87368ej1aj.fsf@tynnyri.adurom.net>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Hello,

On Tuesday, 5 May 2020 09:20:20 CEST Kalle Valo wrote:
> Frank Sch=E4fer <fschaefer.oss@googlemail.com> writes:
> >
> > Am 25.04.20 um 11:28 schrieb Christian Lamparter:
> >> This patch follows up on a bug-report by Frank Sch=E4fer that
> >> discovered P2P GO wasn't working with wpa_supplicant.
> >> This patch removes part of the broken P2P GO support but
> >> keeps the vif switchover code in place.
> >
> > Hmm... no way to fix it ?
> > P2P-GO seems to work fine with p2p_no_group_iface=3D1, so do you really
> > think it's a good idea / required to remove the whole thing ?
> >
> >> Cc: <stable@vger.kernel.org>
> >
> > Are you sure about that ?
> > People might be using it...
>=20
> Christian, what should I do? Take the patch or drop it?

Well, the way I see it: AR9170's silicon die has been cast before
P2P was a thing. And while it was nice back in '10 then to had have
something to test ath9k with, by todays standards the lack of features
like separate TSF sync and the cacheless BA makes it so that it's holding
back the performance and connection quality of all the clients which are
connected to it.

So, I think we'll just kicking down the can on that and I'm sorry that
I gave the people  the wrong impression. There are much better chips now
that came with P2P in mind.=20

So: please take the patch.

Cheers
Christian