Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp1867851ybj; Wed, 6 May 2020 06:52:36 -0700 (PDT) X-Google-Smtp-Source: APiQypL7LKvqZUOVKV1opPeMH7H5UHOryfI7Zr5Jv8wTZN4JkmZazmT7DO9V0bm4diz+DneTp6t4 X-Received: by 2002:a17:906:30c3:: with SMTP id b3mr7620518ejb.126.1588773156133; Wed, 06 May 2020 06:52:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588773156; cv=none; d=google.com; s=arc-20160816; b=H21PPQMSE0gDxsvFJoBNIYEXiAYgiLwOSqIsFh2Zb0waJ65cy2YZsTgtQDjxU/zegv vkC8RoIc+oAKoz8aTdTopDj/Cr3IqtGoHOu0It5zQBq6IEjPbV9Ktey+BsoDIm1h+BU8 VJFS3QF+IZI42EBxizMZfOOucVHZ2ivYKiD8shy01MmuP1orTqZm++iEsLCZ6XTjYE2q xaCL2s9p6c4kPMiWXb6YwL9Wrlj2oIYaNHn9nwCfcTj+bs/J70LXwpMaDtwtPxaAR8Ul ud82r31wPAhoE2SuNEGTRM3sxeK18xVaxEMfbSnYY2WQgDRG8cAVUdd5bxm/YMaREs4Q +2FA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:organization:references:in-reply-to:date:cc:to:from :subject:message-id:ironport-sdr:ironport-sdr; bh=dcFT7QnKWlkUDH0UCut/k1b9qKbYB/4d+4VbkQWKMS4=; b=gvC7Eovu5JnugKLgVhSGE7crpWkxd8TcrqN4n+R+dfxd2Zx5NZZG65/3RHnLVEDz7X jkHYh/Vf9GawDpg8Yc8IqpH9mxExSQF3oew8XwoOsiNOr/vqbX73Npe3gLQweawvxhTJ cuToVAZa6v1VqemuHNbKNxn0MTwRMLg0t21D0SDzZMaXs/MOrpaAp7Yzq/Cn12GfXCjF PhvDJdqK/xSsghRxtDNLc5B1HDlaWMAKBRg/qvVRK8RsjmNh1S28wF+PenayvG2hDH0C Y4aQ9xEn3kPRhnDwt0vOhoxL0VSmz26a6+wrFOUNvQhp8ZT9uXVSEEWUz0ApTssPu4W9 EaEA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bq12si1168698ejb.472.2020.05.06.06.52.11; Wed, 06 May 2020 06:52:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728803AbgEFNvZ (ORCPT + 99 others); Wed, 6 May 2020 09:51:25 -0400 Received: from mga18.intel.com ([134.134.136.126]:49986 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726268AbgEFNvZ (ORCPT ); Wed, 6 May 2020 09:51:25 -0400 IronPort-SDR: 5WfPlfjMe6qWCKw8sNqcrOONmhepX64xDwuYBNAAFtdj7O2y5HNCqg83tqKxLXVQni3K2rhqOE WUbc6iAfwsMg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2020 06:51:24 -0700 IronPort-SDR: m8nwacp2R8DmPdZZRMDkHjX40n5VlhkEVs907sIOf5X9efKF+Bsn5pWTaqEgIqP4NsARFjRvXh 9YR9BtMvkarw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,359,1583222400"; d="scan'208";a="369797404" Received: from jcalzada-mobl1.amr.corp.intel.com ([10.249.254.200]) by fmsmga001.fm.intel.com with ESMTP; 06 May 2020 06:51:21 -0700 Message-ID: Subject: Re: [PATCH -next] iwlwifi: pcie: Use bitwise instead of arithmetic operator for flags From: Luciano Coelho To: Joe Perches , Samuel Zou , johannes.berg@intel.com, emmanuel.grumbach@intel.com, linuxwifi@intel.com, kvalo@codeaurora.org, davem@davemloft.net Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 06 May 2020 16:51:20 +0300 In-Reply-To: References: <1588734423-33988-1-git-send-email-zou_wei@huawei.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, 2020-05-05 at 20:19 -0700, Joe Perches wrote: > On Wed, 2020-05-06 at 11:07 +0800, Samuel Zou wrote: > > This silences the following coccinelle warning: > > > > "WARNING: sum of probable bitmasks, consider |" > > I suggest instead ignoring bad and irrelevant warnings. > > PREFIX_LEN is 32 not 0x20 or BIT(5) > PCI_DUMP_SIZE is 352 > > > diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c b/drivers/net/wireless/intel/iwlwifi/pcie/trans.c > [] > > @@ -109,9 +109,9 @@ void iwl_trans_pcie_dump_regs(struct iwl_trans *trans) > > > > /* Alloc a max size buffer */ > > alloc_size = PCI_ERR_ROOT_ERR_SRC + 4 + PREFIX_LEN; > > - alloc_size = max_t(u32, alloc_size, PCI_DUMP_SIZE + PREFIX_LEN); > > - alloc_size = max_t(u32, alloc_size, PCI_MEM_DUMP_SIZE + PREFIX_LEN); > > - alloc_size = max_t(u32, alloc_size, PCI_PARENT_DUMP_SIZE + PREFIX_LEN); > > + alloc_size = max_t(u32, alloc_size, PCI_DUMP_SIZE | PREFIX_LEN); > > + alloc_size = max_t(u32, alloc_size, PCI_MEM_DUMP_SIZE | PREFIX_LEN); > > + alloc_size = max_t(u32, alloc_size, PCI_PARENT_DUMP_SIZE | PREFIX_LEN); > > > > buf = kmalloc(alloc_size, GFP_ATOMIC); > > if (!buf) Yeah, those macros are clearly not bitmasks. I'm dropping this patch. -- Cheers, Luca.