Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200507041945.15491-1-yhchuang@realtek.com>
In-Reply-To: <20200507041945.15491-1-yhchuang@realtek.com>
From:   Brian Norris <briannorris@chromium.org>
Date:   Thu, 7 May 2020 12:50:54 -0700
Message-ID: <CA+ASDXOn03T6LJ9vH=rmiVxHfyPpM6KMWgt1oTB+rXNYUZy-YA@mail.gmail.com>
Subject: Re: [PATCH] rtw88: update firmware information and README
To:     Tony Chuang <yhchuang@realtek.com>
Cc:     jwboyer@kernel.org,
        linux-wireless <linux-wireless@vger.kernel.org>,
        linux-firmware@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Wed, May 6, 2020 at 9:19 PM <yhchuang@realtek.com> wrote:
> +    And note that the rtw88 driver is able to support wake-on-wireless LAN
> +    for RTL8822C devices, after kernel v5.6+. So, make sure the firmware
> +    rtw88/rtw8822c_wow_fw.bin is also packed, otherwise the firmware load
> +    fail could be a problem.

For the record, I think it's a bug that your driver will refuse to
work now, when not provided the optional WoW firmware:

https://bugzilla.kernel.org/show_bug.cgi?id=207607

It's fine to hint to packagers that they should include both, but it's
not very kind to kill WiFi entirely just because this features won't
work.

Brian