Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp2061605ybk; Mon, 11 May 2020 11:00:16 -0700 (PDT) X-Google-Smtp-Source: APiQypImAmNQipKqRCuIQlxMG2aUVIFd2/6OhHNuMm/g+puD6srCkI5DVf5o7Uei+1litgIswMt4 X-Received: by 2002:a50:d6d0:: with SMTP id l16mr15092647edj.317.1589220015973; Mon, 11 May 2020 11:00:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589220015; cv=none; d=google.com; s=arc-20160816; b=AXNY0UnfU8nZh2iKqybLM7AFULXt72OL6710gPV4/u5/wDDI0Ds2ZMiepx603j5StI JA/fODunE6tOxFjCHFdc8ItNI+fC5nrnWyQyxvKJs8/xiRc6uWLTirA6ZKy8XmwojoI6 fJyjVFAZuFH1lQ+lke6ugHtb49ySOWM8GClbrhYjeBHAOIHwm4CTOO1wxAxxlSLT5Ht2 iPoy64o9mB8OATjLHYEx37r4v7ocJrLgatjmCRCKaKcAna0gBPqiQZ6qgnVbc11Q82os O4mzRrqVeXxtj2dnxI52HDcGobJtksQljj/vHXmCBttLSGFxYK2kdYhhUxgoUescW+Jl 2PzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:dmarc-filter :dkim-signature; bh=5aXebcZJuDYlRRGCTVoQmJ3tVogsWCDXYtgBFHy+GQg=; b=b0GW7/L4FcfQ0GZ8bep+vDzre3xF0g8FDuE1r+Jdl4VYFMcPY1gc1COtr2nxmXXaBW YBXQ9xw002xxjAhEzpZc8+br0MCyh1vwi8oU12EXyuCT2Ugd20fzFtrCC1NXxdVDPRtI uLdBmwVy4VKDg8GEu/aIC+s0LnyO057d+uFfFuRcTuUz7p7D2imYDH3hVcQRzanZFXSx GB4RlseCTcT1CZdgg0nL5mx7ixNDD5t2NwS5iSjr190xcNxUKKhU1gu2lpWgZ0fylQsm Mv40pjEYssVdZtewJy0T0hrAmgO6SsyWJQbol/gZZpL5F6llbW12GXht2ahpQDAUr9RO 8SkQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b="VeK4gTO/"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id rn23si6496095ejb.331.2020.05.11.10.59.37; Mon, 11 May 2020 11:00:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b="VeK4gTO/"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730909AbgEKR7Y (ORCPT + 99 others); Mon, 11 May 2020 13:59:24 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:47349 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727051AbgEKR7Y (ORCPT ); Mon, 11 May 2020 13:59:24 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1589219963; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=5aXebcZJuDYlRRGCTVoQmJ3tVogsWCDXYtgBFHy+GQg=; b=VeK4gTO/FJHJgBOrf0QmhfyjLT+wD74861lVEkEBaUninpPcNY3XDAn4+hk9NpMF0th5n3kR uCCGHqKNxlXrU9GYILdLmroqufNKo0pNp8K40bBqH29sLSod85G/f9d8Ac4JPJizx+LANXzZ IJPQv4w6gyi8wyZFZMtnOqtsatQ= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5eb99277.7f50564a26c0-smtp-out-n05; Mon, 11 May 2020 17:59:19 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id DCA2CC433CB; Mon, 11 May 2020 17:59:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,SPF_NONE autolearn=ham autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 615CFC433F2; Mon, 11 May 2020 17:59:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 615CFC433F2 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Govind Singh Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH 1/4] ath11k: Add PCI client driver for QCA6390 chipset References: <20200508085850.23363-1-govinds@codeaurora.org> <20200508085850.23363-2-govinds@codeaurora.org> Date: Mon, 11 May 2020 20:59:14 +0300 In-Reply-To: <20200508085850.23363-2-govinds@codeaurora.org> (Govind Singh's message of "Fri, 8 May 2020 14:28:47 +0530") Message-ID: <87h7wm4akt.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Govind Singh writes: > QCA6390 is PCI based 11ax chipset, add > pci client driver for QCA6390 target. > > Signed-off-by: Govind Singh This patch had multiple problems, most important ones were: * a break missing in ath11k_pci_probe() * it's not possible to have static variables in .h files, I fixed by moving the ring variables to core.c in a separate patch: https://patchwork.kernel.org/patch/11541355/ * this patch didn't link (at least when compiling as modules), I fixed those by adding missing EXPORT_SYMBOL() macros Please double check my changes: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=44a28b572070f578914367dc2469cef48ece13f4 -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches