Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 34324C433CB
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Govind Singh <govinds@codeaurora.org>
Cc:     ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
        Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Subject: Re: [PATCH 4/4] ath11k: Register mhi controller device for qca6390
References: <20200508085850.23363-1-govinds@codeaurora.org>
        <20200508085850.23363-5-govinds@codeaurora.org>
Date:   Mon, 11 May 2020 21:03:56 +0300
In-Reply-To: <20200508085850.23363-5-govinds@codeaurora.org> (Govind Singh's
        message of "Fri, 8 May 2020 14:28:50 +0530")
Message-ID: <87d07a4acz.fsf@kamboji.qca.qualcomm.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

+ mani

Govind Singh <govinds@codeaurora.org> writes:

> MHI is a communication protocol to communicate with external
> Qualcomm modems and Wi-Fi chipsets over high speed peripheral buses. Even
> though MHI doesn=E2=80=99t dictate underlying physical layer, protocol an=
d mhi stack
> is structured for PCIe based devices.
>
> Register directly with mhi core layer as a mhi device driver for
> firmware download.
>
> Tested QCA6390 on X86 platform.
> Tested firmware WLAN.HST.1.0.1.c1-00440-QCAHSTSWPLZ_V2_TO_X86-1.
>
> Signed-off-by: Govind Singh <govinds@codeaurora.org>

[...]

> --- a/drivers/net/wireless/ath/ath11k/Kconfig
> +++ b/drivers/net/wireless/ath/ath11k/Kconfig
> @@ -2,7 +2,6 @@
>  config ATH11K
>  	tristate "Qualcomm Technologies 802.11ax chipset support"
>  	depends on MAC80211 && HAS_DMA
> -	depends on REMOTEPROC
>  	depends on CRYPTO_MICHAEL_MIC
>  	depends on ARCH_QCOM || COMPILE_TEST
>  	select ATH_COMMON
> @@ -15,13 +14,13 @@ config ATH11K
>=20=20
>  config ATH11K_AHB
>  	tristate "Qualcomm Technologies 802.11ax chipset AHB support"
> -	depends on ATH11K
> +	depends on ATH11K && REMOTEPROC
>  	---help---
>  	  This module adds support for AHB bus
>=20=20
>  config ATH11K_PCI
>  	tristate "Qualcomm Technologies 802.11ax chipset PCI support"
> -	depends on ATH11K && PCI
> +	depends on ATH11K && PCI && MHI_BUS
>  	---help---
>  	  This module adds support for PCIE bus

Currently ATH11K_PCI is not visible if MHI_BUS is disabled, which I'm
worried will confuse the users. I wonder if we should use 'select
MHI_BUS' instead? That way ATH11K_PCI would be visible even if MHI_BUS
is disabled.

And what about QRTR_MHI? Mani, any suggestions?

--=20
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc=
hes