Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 12 May 2020 12:43:23 +0530
From:   Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To:     Kalle Valo <kvalo@codeaurora.org>
Cc:     Govind Singh <govinds@codeaurora.org>, ath11k@lists.infradead.org,
        linux-wireless@vger.kernel.org
Subject: Re: [PATCH 4/4] ath11k: Register mhi controller device for qca6390
Message-ID: <20200512071323.GI4928@Mani-XPS-13-9360>
References: <20200508085850.23363-1-govinds@codeaurora.org>
 <20200508085850.23363-5-govinds@codeaurora.org>
 <87d07a4acz.fsf@kamboji.qca.qualcomm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <87d07a4acz.fsf@kamboji.qca.qualcomm.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Hi Kalle,

On Mon, May 11, 2020 at 09:03:56PM +0300, Kalle Valo wrote:
> + mani
> 
> Govind Singh <govinds@codeaurora.org> writes:
> 
> > MHI is a communication protocol to communicate with external
> > Qualcomm modems and Wi-Fi chipsets over high speed peripheral buses. Even
> > though MHI doesn’t dictate underlying physical layer, protocol and mhi stack
> > is structured for PCIe based devices.
> >
> > Register directly with mhi core layer as a mhi device driver for
> > firmware download.
> >
> > Tested QCA6390 on X86 platform.
> > Tested firmware WLAN.HST.1.0.1.c1-00440-QCAHSTSWPLZ_V2_TO_X86-1.
> >
> > Signed-off-by: Govind Singh <govinds@codeaurora.org>
> 

Ah,finally!

> [...]
> 
> > --- a/drivers/net/wireless/ath/ath11k/Kconfig
> > +++ b/drivers/net/wireless/ath/ath11k/Kconfig
> > @@ -2,7 +2,6 @@
> >  config ATH11K
> >  	tristate "Qualcomm Technologies 802.11ax chipset support"
> >  	depends on MAC80211 && HAS_DMA
> > -	depends on REMOTEPROC
> >  	depends on CRYPTO_MICHAEL_MIC
> >  	depends on ARCH_QCOM || COMPILE_TEST
> >  	select ATH_COMMON
> > @@ -15,13 +14,13 @@ config ATH11K
> >  
> >  config ATH11K_AHB
> >  	tristate "Qualcomm Technologies 802.11ax chipset AHB support"
> > -	depends on ATH11K
> > +	depends on ATH11K && REMOTEPROC
> >  	---help---
> >  	  This module adds support for AHB bus
> >  
> >  config ATH11K_PCI
> >  	tristate "Qualcomm Technologies 802.11ax chipset PCI support"
> > -	depends on ATH11K && PCI
> > +	depends on ATH11K && PCI && MHI_BUS
> >  	---help---
> >  	  This module adds support for PCIE bus
> 
> Currently ATH11K_PCI is not visible if MHI_BUS is disabled, which I'm
> worried will confuse the users. I wonder if we should use 'select
> MHI_BUS' instead? That way ATH11K_PCI would be visible even if MHI_BUS
> is disabled.
> 

Right, this sounds good to me.

> And what about QRTR_MHI? Mani, any suggestions?
> 

Are you asking for Kconfig dependency? If yes, then you need to select it here
also as you can't do much without it.

Btw, I'm not CCed for the patch so I haven't looked at it. But we have made few
changes to the MHI stack which will impact the controller drivers. So I'd
suggest you to rebase MHI controller patch on top of mhi-next [1]. The proposed
changes in MHI will hopefully land in 5.8.

Thanks,
Mani

[1] https://git.kernel.org/pub/scm/linux/kernel/git/mani/mhi.git/log/?h=mhi-next

> -- 
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches