Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp627026ybk; Wed, 13 May 2020 08:52:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyFT6HyNWxcZNOFJjlsO2Ix6I/F0xXYZbQwnh+P2J4v69kIdkiqMlGHIsX1irKsJPecS9zb X-Received: by 2002:a17:906:7e17:: with SMTP id e23mr1573789ejr.172.1589385145392; Wed, 13 May 2020 08:52:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589385145; cv=none; d=google.com; s=arc-20160816; b=gYIBISFhxj7YtrRjgimQe1N//d8dLFeL4OQnkSwcTlYmm/8pbzy5Qn9GyS/09t2sVJ yfX/n3Q4xk0a9I1yHZDPj0qEiHtDLpdlDNmxyFLiVF+rlpod3vbJ+yyTQ6SuD35Ihnhr C+cfeOe2WAz2XNwuWhpws2aUPZIidwOUHTNMrtjBcDuJ1u+u9vsyNjj2+WoDnTTcNzlS C+Gw8JrimDef5linLEfpXtkuGYFx36kbpUwhqKIY4AKdtlyNsilwK+pTSIl33kHRlrL5 Z5OhUDe8YegaQ0HwlzYVwJUoEhjZrdgJXgiK9wjkNOchQfJBbZcohrvrAA4TRQnhjlmb wQPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature; bh=erXaHco75fJTxrMeOsFqv16ZcSBhLgGjXVCw9EInTJo=; b=sChmTELrlTYKsCPDpR1dEXIdx8nuAWqGRwZFrQ7JnqE4jiizzxvFU06+llmHuKwNm8 WZZj62XqWgGhfP6RnubQcoBHHZ6iQzp3LUA3r0k80mF3/wGyDSoq/Xhm51yEdUdoKlX5 8+3DvJBGJ/axFv2FvcDgf8jVXz+gcUUOmLIp4MuJ6SrpJiweMG604BQi7pKwLVXPgT/3 83BnLrcUuPnngvHpUeBzxHATO4lIYSSXQWpe8Ra59g/pMJspvOr+zwl4aujcWJ9l+rhE 3fE1DcWVrqb0daBtGVxyER9eCwdsMsp8flQFzwJaWYGxPOYW9jV3DRsNsIM9fi3jJGKt XI3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b="cTyFS/9r"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k29si6258193edj.567.2020.05.13.08.51.55; Wed, 13 May 2020 08:52:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b="cTyFS/9r"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389336AbgEMPs3 (ORCPT + 99 others); Wed, 13 May 2020 11:48:29 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:59183 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389178AbgEMPs2 (ORCPT ); Wed, 13 May 2020 11:48:28 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1589384908; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=erXaHco75fJTxrMeOsFqv16ZcSBhLgGjXVCw9EInTJo=; b=cTyFS/9rZMH+PKRzpFl2xvQiZ2DfCE0e8C8+uJiuODHUnm85oxIyqFhFMCAcaF+s9MBdpbaU 8EQsmu7iNv3+R4VkoMN95+LdzFfxgMTHuuMhxalHV86uAhi641Mmr0pErKHZgZ+wHul6cJNt EP/ora3kW2+Za3eXurhvdohi5hU= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5ebc16bc.7fb563215a40-smtp-out-n02; Wed, 13 May 2020 15:48:12 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 25A04C433D2; Wed, 13 May 2020 15:48:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.5 required=2.0 tests=ALL_TRUSTED,MISSING_DATE, MISSING_MID,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id A1A0EC433F2; Wed, 13 May 2020 15:48:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A1A0EC433F2 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] brcmfmac: fix WPA/WPA2-PSK 4-way handshake offload and SAE offload failures From: Kalle Valo In-Reply-To: <1589277788-119966-1-git-send-email-chi-hsien.lin@cypress.com> References: <1589277788-119966-1-git-send-email-chi-hsien.lin@cypress.com> To: Chi-Hsien Lin Cc: linux-wireless@vger.kernel.org, brcm80211-dev-list@broadcom.com, brcm80211-dev-list@cypress.com, Arend van Spriel , Franky Lin , Hante Meuleman , Wright Feng , Chung-Hsien Hsu , Chi-Hsien Lin User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20200513154812.25A04C433D2@smtp.codeaurora.org> Date: Wed, 13 May 2020 15:48:12 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Chi-Hsien Lin wrote: > From: Chung-Hsien Hsu > > An incorrect value of use_fwsup is set for 4-way handshake offload for > WPA//WPA2-PSK, caused by commit 3b1e0a7bdfee ("brcmfmac: add support for > SAE authentication offload"). It results in missing bit > BRCMF_VIF_STATUS_EAP_SUCCESS set in brcmf_is_linkup() and causes the > failure. This patch correct the value for the case. > > Also setting bit BRCMF_VIF_STATUS_EAP_SUCCESS for SAE offload case in > brcmf_is_linkup() to fix SAE offload failure. > > Fixes: 3b1e0a7bdfee ("brcmfmac: add support for SAE authentication offload") > Signed-off-by: Chung-Hsien Hsu > Signed-off-by: Chi-Hsien Lin Patch applied to wireless-drivers-next.git, thanks. b2fe11f07773 brcmfmac: fix WPA/WPA2-PSK 4-way handshake offload and SAE offload failures -- https://patchwork.kernel.org/patch/11542809/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches