Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp635485ybk; Wed, 13 May 2020 09:04:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzgqviLqgBNCx00rAeSsz9Tf454X7ZTFJOh687ljs1UJjEbxwG3zpeKA837WnAXgRVwuoJ5 X-Received: by 2002:adf:f783:: with SMTP id q3mr56295wrp.348.1589385882756; Wed, 13 May 2020 09:04:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589385882; cv=none; d=google.com; s=arc-20160816; b=pVJxVW2n3a/m4wIMUcdLnEuBxjW7pvrZKJd4i3QqA5FmLiXlEHzdpm2fYc1jSBJFyD ptLVIP4SQJtG4LWTWtImIG/jC6JlY2DzZmpzB47a8PlZjY0LFB4lqzi8OzfSsQTew6fK 1f9fgui0JM44il2oI1heea0HpU8ZnfCmd7IjJCVEAZfFDohwxWTOj1/l72sEShJaBJwo N4Mi3JaXkIhFnSPxyIqwo8ikFIyry4/uncbokOhhumq9dOKkBXdd6fTZudOky3UgObBn tsTz9KjhsvmSvIZcVLle4tuCz7XeZusTfgIfwkI/ZztcO2f8TPkExYFrvv9rtfB/PAD/ F6Jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature; bh=IBcvEQR1Lr6n5Ys8KKpqQ3yJ5ww8Rfql4MzxV2zjol8=; b=quB0gz2s+iCqAkUTfOiGR9vV1fUkhcbll958swrUHG4OuGisDVmHjoICX/n5iAlHUT 1mUlt/NV/lps0A/yxY3lLDkXoFv31NwR/F57MzVkX2YELi8ws0yenFCapOsaUL2k4T6A jRZQA3ZdKCAJCiq+qBxuTNaZGMoCAYmJ3jLHpB66jc9qxmt+w5FQmdondNZOiO4SjjvP BnlLz/Ar99EIszILJVrbO3NRRBmYd5Ywiyadl1eR7FivgoS9K0ayrj9PH1Qva6m3b9Cb yulQtIzYSLZc5X9wfm0CH48SVyCbgOARJPOThKznYo7Cmh3sMn/a2LahcMNp0mUk10ye rXLg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=GyeuYrQH; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e1si77874ejr.438.2020.05.13.09.04.17; Wed, 13 May 2020 09:04:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=GyeuYrQH; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730657AbgEMQD1 (ORCPT + 99 others); Wed, 13 May 2020 12:03:27 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:50547 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730291AbgEMQD0 (ORCPT ); Wed, 13 May 2020 12:03:26 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1589385806; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=IBcvEQR1Lr6n5Ys8KKpqQ3yJ5ww8Rfql4MzxV2zjol8=; b=GyeuYrQHGFXA2FYlvBzgz4ecwAak7endtsthBf/ZpPPOgGR8C/I/Bhhw2bWkV9aujpcQqYL7 pYplXbJDcUYUG6IA8ypY7JzAeOwCuhnS/kHLAdNxj/fwcfgo5yNkprvYUi3+OKnWplj3PYlU 21pBgCzedhzB1/Z9MHdic/wxzN4= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5ebc1a02.7f1cb31d5ed8-smtp-out-n01; Wed, 13 May 2020 16:02:10 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 8CABBC433BA; Wed, 13 May 2020 16:02:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.5 required=2.0 tests=ALL_TRUSTED,MISSING_DATE, MISSING_MID,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 92CB0C433BA; Wed, 13 May 2020 16:02:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 92CB0C433BA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2] ath11k: fix htt stats module not handle multiple skbs From: Kalle Valo In-Reply-To: <1589221074-28778-1-git-send-email-pradeepc@codeaurora.org> References: <1589221074-28778-1-git-send-email-pradeepc@codeaurora.org> To: Pradeep Kumar Chitrapu Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, Pradeep Kumar Chitrapu , Miles Hu User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20200513160209.8CABBC433BA@smtp.codeaurora.org> Date: Wed, 13 May 2020 16:02:09 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Pradeep Kumar Chitrapu wrote: > HTT EXT stats comes in stream of TLVs spanning over multiple > messages. Currently completion is being sent for each message > which is creating a race where stats_req is being accessed > for filling in second message after the memory is already > freed in release operation. Fix this by issuing completion > once all the messages are received and processed. Driver > knows this info from DONE bit set in htt msg. > > Also fix locking required for htt stats. > > Co-developed-by: Miles Hu > Signed-off-by: Miles Hu > Signed-off-by: Pradeep Kumar Chitrapu > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 012f81456818 ath11k: fix htt stats module not handle multiple skbs -- https://patchwork.kernel.org/patch/11541413/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches