Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200507041945.15491-1-yhchuang@realtek.com>
In-Reply-To: <20200507041945.15491-1-yhchuang@realtek.com>
From:   Josh Boyer <jwboyer@kernel.org>
Date:   Sun, 17 May 2020 14:51:12 -0400
Message-ID: <CA+5PVA5TxEnvUr1y+i5405R1TV=QkdyoU0V-RzGpVm0XFeU3dg@mail.gmail.com>
Subject: Re: [PATCH] rtw88: update firmware information and README
To:     Tony Chuang <yhchuang@realtek.com>
Cc:     Linux Wireless <linux-wireless@vger.kernel.org>,
        linux-firmware@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Applied and pushed out.

josh

On Thu, May 7, 2020 at 12:19 AM <yhchuang@realtek.com> wrote:
>
> From: Yan-Hsuan Chuang <yhchuang@realtek.com>
>
> The rtw88/README should claim support for RTL8723DE devices, add them.
>
> And also there will have confusion that the 802.11ac driver rtw88
> supports an 802.11n device RTL8723DE, add the information to WHENCE.
>
> To prevent some fo the distros not including WOW firmware but have WOW
> support and cannot load firmware at the end, add a note for it.
>
> Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
> ---
>  WHENCE       | 8 ++++++++
>  rtw88/README | 3 +++
>  2 files changed, 11 insertions(+)
>
> diff --git a/WHENCE b/WHENCE
> index 010d1f8..4fe51b2 100644
> --- a/WHENCE
> +++ b/WHENCE
> @@ -2872,6 +2872,14 @@ File: rtw88/rtw8723d_fw.bin
>
>  Licence: Redistributable. See LICENCE.rtlwifi_firmware.txt for details.
>
> +    These firmware should be put under /lib/firmware/rtw88/
> +    And note that the rtw88 driver is able to support wake-on-wireless LAN
> +    for RTL8822C devices, after kernel v5.6+. So, make sure the firmware
> +    rtw88/rtw8822c_wow_fw.bin is also packed, otherwise the firmware load
> +    fail could be a problem.
> +    Although RTL8723D devices are 802.11n device, they are also supported
> +    by rtw88 because the hardware arch is similar.
> +
>  --------------------------------------------------------------------------
>
>  Driver: rtl8192ee - Realtek 802.11n WLAN driver for RTL8192EE
> diff --git a/rtw88/README b/rtw88/README
> index 7ee24b3..b2992be 100644
> --- a/rtw88/README
> +++ b/rtw88/README
> @@ -26,3 +26,6 @@ RTL8822CE
>      rtw8822c_fw.bin
>      rtw8822c_wow_fw.bin
>
> +RTL8723DE
> +    rtw8723d_fw.bin
> +
> --
> 2.17.1
>